Skip to content

Conversation

@shilman
Copy link
Member

@shilman shilman commented May 28, 2017

Issue: #1047

What I did

  • make format match our linting rules
  • collapse PR link in markdown, since github doesn’t do it
    automagically?
  • use updated PR titles and labels after one pass of cleanup

How to test

N/A

- make format match our linting rules
- collapse PR link in markdown, since github doesn’t do it
automagically?
- use updated PR titles and labels after one pass of cleanup
@shilman shilman requested a review from ndelangen May 28, 2017 04:17
@shilman shilman added in progress cleanup Minor cleanup style change that won't show up in release changelog labels May 28, 2017
@codecov
Copy link

codecov bot commented May 28, 2017

Codecov Report

Merging #1140 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1140   +/-   ##
=======================================
  Coverage   12.84%   12.84%           
=======================================
  Files         198      198           
  Lines        4540     4540           
  Branches      718      718           
=======================================
  Hits          583      583           
  Misses       3322     3322           
  Partials      635      635
Impacted Files Coverage Δ
app/react-native/src/manager/provider.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06d4223...997130f. Read the comment docs.

@shilman shilman merged commit 641a30d into master May 28, 2017
@shilman shilman deleted the 1047-update-release-notes branch May 28, 2017 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Minor cleanup style change that won't show up in release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants