Fixed withKnobs definition. #1164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1164 +/- ##
=======================================
Coverage 12.72% 12.72%
=======================================
Files 199 199
Lines 4582 4582
Branches 727 727
=======================================
Hits 583 583
Misses 3356 3356
Partials 643 643Continue to review full report at Codecov.
|
ndelangen
approved these changes
May 30, 2017
ndelangen
added
addon: knobs
maintenance
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1160
What I did
Previously I released an update for addon-knobs (added method withKnobsOptions). By doing that I screwed up previously existing method withKnobs. Now both methods should work.