Skip to content

Conversation

@shilman
Copy link
Member

@shilman shilman commented Jun 8, 2017

Issue: N/A

What I did

  • link on featured users
  • thumbnail/link on examples page

How to test

cd docs
yarn install && yarn dev
open http://localhost:8000
open http://localhost:8000/examples

- link on featured users
- thumbnail/link on examples page
@shilman shilman added in progress documentation cleanup Minor cleanup style change that won't show up in release changelog and removed in progress labels Jun 8, 2017
@shilman shilman requested review from ndelangen, usulpro and xavxyz June 8, 2017 08:18
@codecov
Copy link

codecov bot commented Jun 8, 2017

Codecov Report

Merging #1217 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1217   +/-   ##
======================================
  Coverage    13.7%   13.7%           
======================================
  Files         207     207           
  Lines        4647    4647           
  Branches      510     593   +83     
======================================
  Hits          637     637           
+ Misses       3570    3498   -72     
- Partials      440     512   +72
Impacted Files Coverage Δ
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
app/react/src/client/preview/render.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 0% <0%> (ø) ⬆️
addons/storyshots/src/test-bodies.js 0% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/left_panel/header.js 27.58% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/left_panel.js 20% <0%> (ø) ⬆️
app/react/src/client/preview/reducer.js 0% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fe179b...6199424. Read the comment docs.

@shilman
Copy link
Member Author

shilman commented Jun 8, 2017

Self-merging if I don't hear back soon since it's a trivial change 👿

Copy link
Member

@xavxyz xavxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial change, but so great! ❤️

Dope storybook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Minor cleanup style change that won't show up in release changelog documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants