Skip to content

Conversation

@shilman
Copy link
Member

@shilman shilman commented Jun 22, 2017

Issue: N/A

What I did

Travis builds like this one (#1337) are failing mysteriously all of a sudden. The only recent change that could be related (AFAIK) is my addition of npm5's package-lock.json to the repo.

This change removes all package-lock.json files, and also adds them to gitignore for now.

How to test

@shilman shilman requested a review from tmeasday June 22, 2017 15:08
@shilman shilman requested a review from ndelangen June 22, 2017 15:08
@storybookbot
Copy link
Collaborator

Fails
🚫

PR is not labeled with one of: ["cleanup","breaking","feature","bug","documentation","maintenance","greenkeeper","other"]

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Jun 22, 2017

Codecov Report

Merging #1338 into master will increase coverage by 4.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1338      +/-   ##
==========================================
+ Coverage    9.43%   13.76%   +4.32%     
==========================================
  Files         204      202       -2     
  Lines        4630     4621       -9     
  Branches      518      588      +70     
==========================================
+ Hits          437      636     +199     
+ Misses       3716     3464     -252     
- Partials      477      521      +44
Impacted Files Coverage Δ
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
lib/ui/src/modules/api/configs/init_api.js 40.47% <0%> (ø) ⬆️
app/react/src/client/preview/init.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/reducer.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
...src/server/config/WatchMissingNodeModulesPlugin.js 0% <0%> (ø) ⬆️
lib/ui/src/context.js 0% <0%> (ø) ⬆️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0520eab...7787b9b. Read the comment docs.

@shilman shilman added the maintenance User-facing maintenance tasks label Jun 22, 2017
Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance User-facing maintenance tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants