Doc Blocks: Add title to Meta prop types
#23370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed ts error No title prop defined:
Aryan1982
approved these changes
Jul 8, 2023
iqbalcodes6602
commented
Jul 10, 2023
Contributor
Author
iqbalcodes6602
left a comment
iqbalcodes6602
left a comment
There was a problem hiding this comment.
updated branch
MWhite-22
approved these changes
Jul 11, 2023
MWhite-22
left a comment
MWhite-22
left a comment
There was a problem hiding this comment.
Left a minor comment for visibility purposes but overall the change looks good. Nice work!
code/ui/blocks/src/blocks/Meta.tsx
Outdated
| * and gets transformed into a default export underneath the hood. | ||
| */ | ||
| export const Meta: FC<MetaProps> = ({ of }) => { | ||
| export const Meta: FC<MetaProps> = ({ of, title }) => { |
There was a problem hiding this comment.
I don't think you need to destructure the title out of props here as it's never being used.
Contributor
Author
There was a problem hiding this comment.
@MWhite-22 thank u for responding. I have updated this please can you consider this PR for merging so that i can get my first PR merged.
JReinhold
approved these changes
Aug 29, 2023
Contributor
JReinhold
left a comment
JReinhold
left a comment
There was a problem hiding this comment.
Sorry for being slow here @iqbalcodes6602 ! Thank you for this 💪
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed ts error No title prop defined:
Closes #22910
What I did
I defined a variable title with type String so that TS no longer has undefined prop.
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]