Skip to content

Conversation

@yannbf
Copy link
Member

@yannbf yannbf commented Aug 8, 2023

Closes #

What I did

This PR introduces the visual tests addon to Storybook UI

TODO:

  • The addon does not pick up the storybook build script, once fixed and updated this PR can be merged

How to test

  1. Run yarn storybook:ui in code
  2. Open any story
  3. Check the visual tests addon panel
image

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf added the build Internal-facing build tooling & test updates label Aug 8, 2023
@socket-security
Copy link

socket-security bot commented Aug 8, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/uuid 8.3.4 None +0 6.67 kB types
@chromaui/addon-visual-tests 0.0.49 network, environment +46 19.6 MB tmeasday

@socket-security
Copy link

socket-security bot commented Aug 8, 2023

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Uses eval react-popper 1.3.11

Next steps

What is eval?

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@yannbf yannbf force-pushed the yann/add-chromatic-addon branch from 25097fe to ae34e24 Compare August 25, 2023 07:19
@yannbf yannbf force-pushed the yann/add-chromatic-addon branch 2 times, most recently from 657a1c2 to 552e75e Compare August 29, 2023 19:15
@yannbf yannbf force-pushed the yann/add-chromatic-addon branch from 552e75e to 3bd2046 Compare August 30, 2023 20:56
@yannbf yannbf merged commit a767c8b into next Sep 5, 2023
@yannbf yannbf deleted the yann/add-chromatic-addon branch September 5, 2023 07:19
@github-actions github-actions bot mentioned this pull request Sep 5, 2023
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants