-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Development: Manage Node version with .nvmrc #24015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
385309d to
3134dbd
Compare
|
Danger task failing on branch due to a 403 on the GitHub user "Resource not accessible by integration". "Could not add a commit status, the GitHub token for Danger does not have access rights." |
JReinhold
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me! 👍
Don't worry about CircleCI, it's not worth it right now. One day we might migrate to dynamic configs for other reasons.
I'll defer to @kylegach for the docs changes.
3134dbd to
c3580a3
Compare
kylegach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @johnhunter. I have no issue with these docs changes.
I'm fairly sure most contributors use nvm, though...
c3580a3 to
aeff1fd
Compare
|
Thanks @kylegach
I think that's true, for them the changes will just work and for new contributors fnm is a faster tool. I'm not sure of the process - @JReinhold are you able to merge this PR? |
961cb8f to
65329ea
Compare
|
Force-pushed from merge conflicts with upstream next |
65329ea to
6c4dec1
Compare
Add .nvmrc config for latest node 16
Non-publish actions
Publish and release related but these actions already used hardcoded node 16 versions.
6c4dec1 to
f534bc6
Compare
Development: Manage Node version with .nvmrc
|
Release |
Closes #
What I did
Implements changes discussed in #23909 and reverts changes from PR #23709
package.json.nvmrcfile to the project root.nvmrcrather than hardcoded node versions.Open issues for review
.nvmrcfile would be involved. It might be possible with Dynamic configs although maybe not worth it..nvmrcnode version in the publish script. It looks like these would be called in the canary-release and publish actions which where already hardcoded to node@16Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>