Skip to content

Conversation

@j3rem1e
Copy link
Contributor

@j3rem1e j3rem1e commented Aug 30, 2023

Closes #24019

What I did

The fix is explained in the referenced issue.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@j3rem1e
Copy link
Contributor Author

j3rem1e commented Aug 31, 2023

I don't think anymore it's a good idea to remove the action here. It's used in the auto-registration of actions un PreviewRenderer.svelte.

I suppose we should try to hide argsType with category 'event' in the source generator. I will rework this PR.

@yannbf yannbf changed the title Fix generated properties on Svelte event handler Svelte: Fix generated properties on Svelte event handler Sep 4, 2023
@yannbf
Copy link
Member

yannbf commented Sep 4, 2023

Hey @j3rem1e thank you so much for your contribution <3
@JReinhold could you please take a look? Thanks!

Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@kasperpeulen kasperpeulen merged commit d627022 into storybookjs:next Sep 6, 2023
@github-actions github-actions bot mentioned this pull request Sep 6, 2023
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Generated code from a Svelte composant shows invalid properties

5 participants