-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Sandboxes: Use Node 18 to generate Angular prerelease sandboxes #24033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| angular-prerelease-sandbox: | ||
| executor: | ||
| class: large | ||
| name: sb_playwright |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sb_playwright is on Node 18, which is lucky for us.
| env: | ||
| YARN_ENABLE_IMMUTABLE_INSTALLS: false | ||
| CLEANUP_SANDBOX_NODE_MODULES: true | ||
| strategy: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you follow the instructions from line 7 of this file and make sure this change works as expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it failed on the very last character of the workflow, which I've fixed. I don't feel it's necessary to test it again.
…dbox Sandboxes: Use Node 18 to generate Angular prerelease sandboxes (cherry picked from commit 81f61a0)
…dbox Sandboxes: Use Node 18 to generate Angular prerelease sandboxes (cherry picked from commit 81f61a0)
What I did
This PR fixes the issue with Angular prereleases not working in our CI anymore, because they require Node 18.
mainandnextinto one, using the strategy matrix feature instead.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
nextbranch because of the workflow rename, but here's a (cancelled) run where I log that the matrixes are set up correct: https://github.com/storybookjs/storybook/actions/runs/6037790919/job/16382747584This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>