Build: Generate Node 18 sandboxes separately #24188
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
requested review from
JReinhold,
kasperpeulen,
ndelangen,
valentinpalkovic and
vanessayuenn
as code owners
yannbf
commented
Sep 15, 2023
yannbf
force-pushed
the
fix/sandbox-generation
branch
from
e4974d0 to
8e2fcfe
Compare
yannbf
added
ci:daily
yannbf
force-pushed
the
fix/sandbox-generation
branch
5 times, most recently
from
a9a2460 to
e372cbd
Compare
yannbf
commented
Sep 15, 2023
| requires: | ||
| - build | ||
| # - smoke-test-sandboxes: # disabled for now | ||
| # - create-sandboxes: |
Member
Author
There was a problem hiding this comment.
Reminder to uncomment all of this before merging
4 tasks
Member
|
Half this work is done in #24208 This will be left as draft until later. |
yannbf
force-pushed
the
fix/sandbox-generation
branch
from
e372cbd to
e903cca
Compare
Member
|
@yannbf I think this has been superceded by the work done by @valentinpalkovic and me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
nextandmainalso generate angular prereleases in node 18Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
It's quite tricky to test the GH Action code, but I have tested it extensively and was successfully able to generate sandboxes, both in main and next.
Regarding the CircleCI part, it's a matter of pushing code changes and seeing what CircleCI does. I commented out most of the jobs so that we don't spend unnecessary CI time and things are faster.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>