Skip to content

Conversation

@ATREAY
Copy link
Contributor

@ATREAY ATREAY commented Sep 25, 2023

What I did

I have provided additional information regarding the emit() function. This pull request is related to Issue #24050(Fix unclear snippets for Highlight addon docs).

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@jonniebigodes jonniebigodes added documentation ci:docs Run the CI jobs for documentation checks only. labels Sep 30, 2023
@jonniebigodes jonniebigodes self-assigned this Oct 1, 2023
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ATREAY thank you so much for taking on this documentation issue and helping us improve it. 🙏 I left a small item for you to look at, and this should be good to go.

Let me know once you've addressed the feedback, and I'll gladly merge this.

Hope you have a fantastic weekend.

Stay safe

@ATREAY
Copy link
Contributor Author

ATREAY commented Oct 6, 2023

Hi @jonniebigodes, I've made the necessary updates. Could you please take a look when you have a moment?

@ATREAY
Copy link
Contributor Author

ATREAY commented Oct 6, 2023

Hey @jonniebigodes, my bad for not catching on to your previous suggestions, but I've now made the changes as per your guidance. Could you take a look when you have a moment?

@jonniebigodes
Copy link
Contributor

@ATREAY no problem whatsoever, we caught it on time. Appreciate you addressing the feedback so promptly 🙏 ! Once the checklist clears. I'll gladly merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:docs Run the CI jobs for documentation checks only. documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants