Skip to content

Conversation

@shilman
Copy link
Member

@shilman shilman commented Oct 11, 2023

Closes #24427

What I did

  • Update version range to include Lit3 in peer dependency

Checklist for Contributors

Testing

Manual testing

  • Create a lit-vite sandbox
  • Manually upgrade the package.json to Lit3 & re-run yarn
  • Run Storybook & verify everything is working the same as before

🦋 Canary release

This pull request has been released as version 0.0.0-pr-24437-sha-55d6b8d8. Install it by pinning all your Storybook dependencies to that version.

More information
Published version 0.0.0-pr-24437-sha-55d6b8d8
Triggered by @shilman
Repository storybookjs/storybook
Branch shilman/lit3
Commit 55d6b8d8
Datetime Wed Oct 11 10:19:13 UTC 2023 (1697019553)
Workflow run 6481162686

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=24437

@JReinhold JReinhold added ci:daily Run the CI jobs that normally run in the daily job. and removed ci:normal labels Oct 11, 2023
@JReinhold
Copy link
Contributor

Should we update the sandbox templates for Lit to install v3 explicitly until create-vite has been updated with the change?

@shilman
Copy link
Member Author

shilman commented Oct 11, 2023

@JReinhold I think it's OK to wait for the Vite update.

@yannbf
Copy link
Member

yannbf commented Oct 11, 2023

I tested it out, it’s all good!

  • No installation issues with the canary
  • Sandbox in the monorepo is good, all tests passing
  • There doesn’t seem to be any difference in behavior in addons e.g. controls and argtypes, or docs and snippets

@shilman shilman merged commit 7f337b1 into next Oct 11, 2023
@shilman shilman deleted the shilman/lit3 branch October 11, 2023 13:15
@github-actions github-actions bot mentioned this pull request Oct 11, 2023
13 tasks
@yannbf yannbf mentioned this pull request Oct 17, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:daily Run the CI jobs that normally run in the daily job. dependencies web-components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Support for @storybook/web-components for lit 3.0.0

5 participants