Skip to content

Conversation

@valentinpalkovic
Copy link
Contributor

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic merged commit e9f2e1f into next Oct 12, 2023
@valentinpalkovic valentinpalkovic deleted the valentin/fix-sandbox-creation branch October 12, 2023 10:08
@valentinpalkovic valentinpalkovic added build Internal-facing build tooling & test updates bug labels Oct 12, 2023
@valentinpalkovic valentinpalkovic changed the title Fix sandbox creation scripts for main and next Sandboxes: Fix sandbox creation scripts for main and next Oct 12, 2023
@valentinpalkovic valentinpalkovic added the ci:docs Run the CI jobs for documentation checks only. label Oct 12, 2023
@github-actions github-actions bot mentioned this pull request Oct 12, 2023
7 tasks
@shilman shilman removed the bug label Oct 13, 2023
@github-actions github-actions bot mentioned this pull request Oct 13, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants