Skip to content

Conversation

@coliff
Copy link
Contributor

@coliff coliff commented Sep 27, 2024

Recommend installing EditorConfig to help ensure consistent code formatting.

What I did

Added editorconfig VS Code extension to recommended extensions.
https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

This pull request adds the EditorConfig extension to the recommended extensions in VS Code's extensions.json file, promoting consistent code formatting across the project.

  • Added EditorConfig to .vscode/extensions.json as a recommended VS Code extension
  • Minor tooling change that doesn't require code modifications or extensive testing
  • Improves code formatting consistency for developers using VS Code
  • Should be labeled as 'maintenance' for this user-facing tooling update

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@nx-cloud
Copy link

nx-cloud bot commented Sep 27, 2024

View your CI Pipeline Execution ↗ for commit ea7d1a9.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 34s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-22 00:29:54 UTC

@coliff
Copy link
Contributor Author

coliff commented Apr 17, 2025

Can this be merged? It's helpful for contributors.

Recommend installing EditorConfig to help ensure consistent code formatting.
@valentinpalkovic valentinpalkovic added ci:docs Run the CI jobs for documentation checks only. bug build Internal-facing build tooling & test updates and removed bug labels Jun 23, 2025
@valentinpalkovic valentinpalkovic merged commit b316002 into storybookjs:next Jun 23, 2025
8 of 19 checks passed
@coliff coliff deleted the patch-1 branch June 23, 2025 08:55
@github-actions github-actions bot mentioned this pull request Jun 23, 2025
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants