Addon Themes: Deprecate useThemeParameters #30111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
|
|
||
| export function useThemeParameters(context: StoryContext): ThemeParameters { | ||
| return context.parameters[PARAM_KEY] || DEFAULT_THEME_PARAMETERS; | ||
| if (!context) { |
Contributor
There was a problem hiding this comment.
logic: checking for !context seems incorrect - context should always be provided in valid usage
| ` | ||
| ); | ||
|
|
||
| return useParameter<ThemeParameters>(PARAM_KEY, DEFAULT_THEME_PARAMETERS) as ThemeParameters; |
Contributor
There was a problem hiding this comment.
style: casting to ThemeParameters may hide type errors - consider using type guards instead
|
View your CI Pipeline Execution ↗ for commit 1ded935.
☁️ Nx Cloud last updated this comment at |
JReinhold
approved these changes
Dec 19, 2024
yannbf
changed the title
yannbf
force-pushed
the
fix-addon-themes-issue
branch
from
191ca46 to
1ded935
Compare
kylegach
approved these changes
Dec 19, 2024
Contributor
kylegach
left a comment
kylegach
left a comment
There was a problem hiding this comment.
Docs are good; thanks!
(The rest seems good to me, too, fwiw.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Here's my concise review of the changes:
Deprecates the useThemeParameters hook in favor of direct context access for theme parameters in the Storybook addon-themes package, improving code maintainability.
code/addons/themes/docs/api.mdwith migration instructionscode/addons/themes/src/decorators/helpers.tsto handle deprecated hook usage with warningThe changes are focused on removing an unnecessary abstraction layer while maintaining backward compatibility through proper deprecation notices.