-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Docs live examples #3019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Docs live examples #3019
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
46e86bd
Add netlify live examples to readme
igor-dv 2edf49a
Reorder examples
igor-dv ac50449
Remove "master--" prefix for the latest builds
igor-dv 1f2fd75
Add examples to docs
igor-dv 5d44a68
Merge branch 'master' into docs-live-examples
igor-dv ad05bbc
Merge branch 'master' into docs-live-examples
igor-dv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just https://storybooks-official.netlify.com
I'm also not sure about the "React Official" naming, would like to hear from @tmeasday and @ndelangen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I feel some kind of conflict between showing the official storybook UI and showing the examples...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I wouldn't call it that. Don't we have a "React" example too? (
cra-kitchen-sink).official-storybookis like Storybook's storybook. Not quite sure how best to put that ;) Maybe it doesn't actually need to be on this page?