Skip to content

Conversation

@Hypnosphi
Copy link
Member

Issue: When using events addon, you get React warning about the keys, because events don't need to have id field as per docs

@Hypnosphi Hypnosphi added bug addon: events patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 24, 2018
@codecov
Copy link

codecov bot commented Feb 24, 2018

Codecov Report

Merging #3072 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3072   +/-   ##
=======================================
  Coverage   36.08%   36.08%           
=======================================
  Files         438      438           
  Lines        9447     9447           
  Branches      875      907   +32     
=======================================
  Hits         3409     3409           
+ Misses       5498     5460   -38     
- Partials      540      578   +38
Impacted Files Coverage Δ
addons/events/src/components/Panel.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/addon_panel.js 23.52% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
...src/server/config/WatchMissingNodeModulesPlugin.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/shortcuts_help.js 25% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Info.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/stories_panel.js 27.02% <0%> (ø) ⬆️
addons/storysource/src/loader/generate-helpers.js 48.1% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/shortcuts_help.js 12.85% <0%> (ø) ⬆️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03cce7a...70dc583. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 6758750 into master Feb 27, 2018
@Hypnosphi Hypnosphi deleted the event-key-warning branch February 27, 2018 18:39
@Hypnosphi Hypnosphi added patch:done Patch/release PRs already cherry-picked to main/release branch and removed patch:done Patch/release PRs already cherry-picked to main/release branch labels Mar 6, 2018
Hypnosphi added a commit that referenced this pull request Mar 6, 2018
Events addon: fix React keys warning
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 6, 2018
@ghost ghost mentioned this pull request Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addon: events bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants