Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
91edda3
remove ancient code 😅
xeho91 May 6, 2025
7358b5b
simplify to use modern `Component` type from svelte
xeho91 May 6, 2025
a936c26
delete old svelte 4 component from testing
xeho91 May 6, 2025
835e6c4
remove `expect-type` - is bundled into `vitest`
xeho91 May 6, 2025
99bbc59
refactor svelte renderer public-types - simplifcation by using `Compo…
xeho91 May 6, 2025
08d1797
update test types
xeho91 May 6, 2025
10b1563
migrate test decorators to Svelte 5 syntax
xeho91 May 7, 2025
493ece5
Merge branch 'next' into feat/refactor-svelte-renderer-types
JReinhold May 19, 2025
1c97fbd
Merge branch 'next' of github.com:storybookjs/storybook into feat/ref…
JReinhold Sep 24, 2025
726c34f
use runes in portable stories test
JReinhold Sep 25, 2025
edfc194
Merge branch 'next' of github.com:storybookjs/storybook into feat/ref…
JReinhold Sep 26, 2025
1a0d999
upgrade to runes, fix types
JReinhold Sep 26, 2025
3eadd2c
Merge branch 'next' into feat/refactor-svelte-renderer-types
JReinhold Sep 26, 2025
4c110f7
fix lock file
JReinhold Sep 26, 2025
8b2c965
Merge branch 'feat/refactor-svelte-renderer-types' of https://github.…
JReinhold Sep 26, 2025
480f8b0
Update code/renderers/svelte/src/__test__/composeStories/CustomRender…
JReinhold Sep 26, 2025
d428a27
fix type tests
JReinhold Sep 26, 2025
01c7e0d
Merge branch 'feat/refactor-svelte-renderer-types' of https://github.…
JReinhold Sep 26, 2025
49291b2
Merge branch 'next' into feat/refactor-svelte-renderer-types
JReinhold Sep 26, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion code/renderers/svelte/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
"devDependencies": {
"@sveltejs/vite-plugin-svelte": "^6.2.0",
"@testing-library/svelte": "^5.2.4",
"expect-type": "^1.1.0",
"svelte": "^5.39.5",
"svelte-check": "^4.3.2",
"sveltedoc-parser": "^4.2.1",
Expand Down
15 changes: 9 additions & 6 deletions code/renderers/svelte/src/__test__/Button.svelte
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
<script lang="ts">
import { createEventDispatcher } from 'svelte';
interface Props {
disabled: boolean;
label: string;
clicked?: (e: MouseEvent) => void;
}

export let disabled: boolean;
export let label: string;

const dispatch = createEventDispatcher();
// When a Svelte 5 component only uses runes, it is typed as a function component.
// Others are typed as class components. Hence we need to have tests for both shapes.
let { disabled, label, clicked}: Props = $props();
</script>

<button on:click={(e) => dispatch('clicked', e)} on:dblclick on:mousemove {disabled}>
<button onclick={clicked} {disabled}>
{label}
</button>
15 changes: 0 additions & 15 deletions code/renderers/svelte/src/__test__/ButtonV5.svelte

This file was deleted.

10 changes: 8 additions & 2 deletions code/renderers/svelte/src/__test__/Decorator.svelte
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
<script lang="ts">
export let decoratorArg: string;
import type { Snippet } from "svelte";

interface Props {
children: Snippet;
decoratorArg: string;
}
let { children, decoratorArg }: Props = $props();
</script>

<div>
Decorator: {decoratorArg}
<slot />
{@render children()}
</div>
10 changes: 8 additions & 2 deletions code/renderers/svelte/src/__test__/Decorator2.svelte
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
<script lang="ts">
export let decoratorArg2: string;
import type { Snippet } from "svelte";

interface Props {
children: Snippet;
decoratorArg2: string;
}
let { children, decoratorArg2 }: Props = $props();
</script>

<div>
Decorator: {decoratorArg2}
<slot />
{@render children()}
</div>
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ const getCaptionForLocale = (locale: string) => {
}
};

// @ts-expect-error -- incompatibility with Svelte 5 types and CSF
export const CSF2StoryWithLocale: CSF2Story<typeof StoryWithLocaleComponent> = (
args,
{ globals }
Expand Down Expand Up @@ -105,7 +104,7 @@ export const CSF3Button: CSF3Story = {
args: { label: 'foo' },
};

export const CSF3ButtonWithRender: StoryObj<CustomRenderComponent> = {
export const CSF3ButtonWithRender: StoryObj<typeof CustomRenderComponent> = {
args: {
buttonProps: CSF3Button.args,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import Button from './Button.svelte';
import type { ComponentProps } from 'svelte';

export let buttonProps: ComponentProps<typeof Button>;
let { buttonProps }: { buttonProps: ComponentProps<typeof Button> } = $props();
</script>

<div>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
<script>
export let mockFn;
export let loaded;
<script lang="ts">
let {
mockFn,
loaded,
}: {
mockFn: (arg: string) => string;
loaded: { value: string };
} = $props();

let data;

$: if (mockFn && loaded) {
data = mockFn('render');
}
let data = $derived(mockFn && loaded && mockFn('render'));
</script>

<div>
<div data-testid="loaded-data">{loaded.value}</div>
<div data-testid="spy-data">{String(data)}</div>
</div>
</div>
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
<script>
<script lang="ts">
import Button from './Button.svelte';

export let locale;
export let label;

let {
locale,
label,
}: {
locale: string;
label: string;
} = $props();
</script>

<div>
<p>locale: {locale}</p>
<Button label={label} />
</div>
<Button {label} />
</div>
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// @vitest-environment happy-dom
/// <reference types="@testing-library/jest-dom" />;
import { cleanup, render, screen } from '@testing-library/svelte';
import { afterEach, describe, expect, it, vi } from 'vitest';
import { afterEach, describe, expect, it } from 'vitest';

// import '@testing-library/svelte/vitest';
import { expectTypeOf } from 'expect-type';
Expand Down
Loading