Skip to content

Type check production files #31555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrginglymus wants to merge 8 commits into from
Closed

Type check production files #31555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2884be3
Type check production files
mrginglymus May 23, 2025
898fa94
Run check task in prod mode
mrginglymus May 25, 2025
977ccc0
Update remaining packages to support production type checking
mrginglymus May 25, 2025
a6143d7
Merge branch 'next' into typecheck-dist
mrginglymus Jun 8, 2025
8066cc2
Remove seemingly redudant declaration from nextjs-vite
mrginglymus Jun 8, 2025
ef21329
Check task only depends on install
mrginglymus Jun 12, 2025
ae65c7e
Merge branch 'next' into typecheck-dist
mrginglymus Jun 12, 2025
bcffd61
Merge branch 'next' into typecheck-dist
ndelangen Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,11 +282,11 @@ jobs:
- run:
name: Compile
command: |
yarn task --task compile --start-from=auto --no-link --debug
yarn task --task compile --prod --start-from=auto --no-link --debug
- run:
name: Check
command: |
yarn task --task check --start-from=auto --no-link --debug
yarn task --task check --prod --start-from=auto --no-link --debug
- run:
name: Ensure no changes pending
command: |
Expand Down
4 changes: 2 additions & 2 deletions code/addons/a11y/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@
"!src/**/*"
],
"scripts": {
"check": "jiti ../../../scripts/prepare/check.ts",
"prep": "jiti ../../../scripts/prepare/addon-bundle.ts"
Comment on lines -65 to -66
Copy link
Member

@ndelangen ndelangen Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain why these scripts need to be renamed?

Copy link
Contributor Author

@mrginglymus mrginglymus Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I can. I find nx a bit impenetrable, but it seems that if a user runs nx check, and nx finds a script called check in package.json, it'll run that script rather than its own, ignoring all nx config.

So the options were either rename all the check scripts in all package.json, which is churny but not user visible, or rename the top-level nx command, which would potentially confuse users.

"prep": "jiti ../../../scripts/prepare/addon-bundle.ts",
"typecheck": "jiti ../../../scripts/prepare/check.ts"
},
"dependencies": {
"@storybook/global": "^5.0.0",
Expand Down
3 changes: 2 additions & 1 deletion code/addons/a11y/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"projectType": "library",
"targets": {
"build": {}
"build": {},
"check": {}
}
}
4 changes: 2 additions & 2 deletions code/addons/docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@
"!src/**/*"
],
"scripts": {
"check": "jiti ../../../scripts/prepare/check.ts",
"prep": "jiti ../../../scripts/prepare/addon-bundle.ts"
"prep": "jiti ../../../scripts/prepare/addon-bundle.ts",
"typecheck": "jiti ../../../scripts/prepare/check.ts"
},
"dependencies": {
"@mdx-js/react": "^3.0.0",
Expand Down
3 changes: 2 additions & 1 deletion code/addons/docs/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"projectType": "library",
"targets": {
"build": {}
"build": {},
"check": {}
}
}
4 changes: 2 additions & 2 deletions code/addons/jest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@
"!src/**/*"
],
"scripts": {
"check": "jiti ../../../scripts/prepare/check.ts",
"prep": "jiti ../../../scripts/prepare/addon-bundle.ts"
"prep": "jiti ../../../scripts/prepare/addon-bundle.ts",
"typecheck": "jiti ../../../scripts/prepare/check.ts"
},
"dependencies": {
"tiny-invariant": "^1.3.1",
Expand Down
3 changes: 2 additions & 1 deletion code/addons/jest/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"projectType": "library",
"targets": {
"build": {}
"build": {},
"check": {}
}
}
4 changes: 2 additions & 2 deletions code/addons/links/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@
"!src/**/*"
],
"scripts": {
"check": "jiti ../../../scripts/prepare/check.ts",
"prep": "jiti ../../../scripts/prepare/addon-bundle.ts"
"prep": "jiti ../../../scripts/prepare/addon-bundle.ts",
"typecheck": "jiti ../../../scripts/prepare/check.ts"
},
"dependencies": {
"@storybook/global": "^5.0.0"
Expand Down
3 changes: 2 additions & 1 deletion code/addons/links/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"projectType": "library",
"targets": {
"build": {}
"build": {},
"check": {}
}
}
4 changes: 2 additions & 2 deletions code/addons/onboarding/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
"!src/**/*"
],
"scripts": {
"check": "jiti ../../../scripts/prepare/check.ts",
"prep": "jiti ../../../scripts/prepare/addon-bundle.ts"
"prep": "jiti ../../../scripts/prepare/addon-bundle.ts",
"typecheck": "jiti ../../../scripts/prepare/check.ts"
},
"devDependencies": {
"@neoconfetti/react": "^1.0.0",
Expand Down
3 changes: 2 additions & 1 deletion code/addons/onboarding/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"projectType": "library",
"targets": {
"build": {}
"build": {},
"check": {}
}
}
4 changes: 2 additions & 2 deletions code/addons/pseudo-states/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@
"!src/**/*"
],
"scripts": {
"check": "jiti ../../../scripts/prepare/check.ts",
"prep": "jiti ../../../scripts/prepare/addon-bundle.ts"
"prep": "jiti ../../../scripts/prepare/addon-bundle.ts",
"typecheck": "jiti ../../../scripts/prepare/check.ts"
},
"devDependencies": {
"@storybook/icons": "^1.4.0",
Expand Down
3 changes: 2 additions & 1 deletion code/addons/pseudo-states/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"projectType": "library",
"targets": {
"build": {}
"build": {},
"check": {}
}
}
4 changes: 2 additions & 2 deletions code/addons/themes/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@
"!src/**/*"
],
"scripts": {
"check": "jiti ../../../scripts/prepare/check.ts",
"prep": "jiti ../../../scripts/prepare/addon-bundle.ts"
"prep": "jiti ../../../scripts/prepare/addon-bundle.ts",
"typecheck": "jiti ../../../scripts/prepare/check.ts"
},
"dependencies": {
"ts-dedent": "^2.0.0"
Expand Down
3 changes: 2 additions & 1 deletion code/addons/themes/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "addon-themes",
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"targets": {
"build": {}
"build": {},
"check": {}
}
}
4 changes: 2 additions & 2 deletions code/addons/vitest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@
"!src/**/*"
],
"scripts": {
"check": "jiti ../../../scripts/prepare/check.ts",
"prep": "jiti ../../../scripts/prepare/addon-bundle.ts"
"prep": "jiti ../../../scripts/prepare/addon-bundle.ts",
"typecheck": "jiti ../../../scripts/prepare/check.ts"
},
"dependencies": {
"@storybook/global": "^5.0.0",
Expand Down
3 changes: 2 additions & 1 deletion code/addons/vitest/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"projectType": "library",
"targets": {
"build": {}
"build": {},
"check": {}
}
}
4 changes: 2 additions & 2 deletions code/builders/builder-vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
"!src/**/*"
],
"scripts": {
"check": "jiti ../../../scripts/prepare/check.ts",
"prep": "jiti ../../../scripts/prepare/bundle.ts"
"prep": "jiti ../../../scripts/prepare/bundle.ts",
"typecheck": "jiti ../../../scripts/prepare/check.ts"
},
"dependencies": {
"@storybook/csf-plugin": "workspace:*",
Expand Down
3 changes: 2 additions & 1 deletion code/builders/builder-vite/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"projectType": "library",
"targets": {
"build": {}
"build": {},
"check": {}
}
}
4 changes: 2 additions & 2 deletions code/builders/builder-webpack5/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@
"!src/**/*"
],
"scripts": {
"check": "jiti ../../../scripts/prepare/check.ts",
"prep": "jiti ../../../scripts/prepare/bundle.ts"
"prep": "jiti ../../../scripts/prepare/bundle.ts",
"typecheck": "jiti ../../../scripts/prepare/check.ts"
},
"dependencies": {
"@storybook/core-webpack": "workspace:*",
Expand Down
3 changes: 2 additions & 1 deletion code/builders/builder-webpack5/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"projectType": "library",
"targets": {
"build": {}
"build": {},
"check": {}
}
}
3 changes: 2 additions & 1 deletion code/core/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../node_modules/nx/schemas/project-schema.json",
"projectType": "library",
"targets": {
"build": {}
"build": {},
"check": {}
}
}
4 changes: 2 additions & 2 deletions code/frameworks/ember/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@
"!src/**/*"
],
"scripts": {
"check": "jiti ../../../scripts/prepare/check.ts",
"prep": "jiti ../../../scripts/prepare/tsc.ts"
"prep": "jiti ../../../scripts/prepare/tsc.ts",
"typecheck": "jiti ../../../scripts/prepare/check.ts"
},
"dependencies": {
"@storybook/builder-webpack5": "workspace:*",
Expand Down
3 changes: 2 additions & 1 deletion code/frameworks/ember/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"projectType": "library",
"targets": {
"build": {}
"build": {},
"check": {}
}
}
4 changes: 2 additions & 2 deletions code/frameworks/html-vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@
"!src/**/*"
],
"scripts": {
"check": "jiti ../../../scripts/prepare/check.ts",
"prep": "jiti ../../../scripts/prepare/bundle.ts"
"prep": "jiti ../../../scripts/prepare/bundle.ts",
"typecheck": "jiti ../../../scripts/prepare/check.ts"
},
"dependencies": {
"@storybook/builder-vite": "workspace:*",
Expand Down
3 changes: 2 additions & 1 deletion code/frameworks/html-vite/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"projectType": "library",
"targets": {
"build": {}
"build": {},
"check": {}
}
}
4 changes: 2 additions & 2 deletions code/frameworks/nextjs-vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@
"!src/**/*"
],
"scripts": {
"check": "jiti ../../../scripts/prepare/check.ts",
"prep": "jiti ../../../scripts/prepare/bundle.ts"
"prep": "jiti ../../../scripts/prepare/bundle.ts",
"typecheck": "jiti ../../../scripts/prepare/check.ts"
},
"dependencies": {
"@storybook/builder-vite": "workspace:*",
Expand Down
3 changes: 2 additions & 1 deletion code/frameworks/nextjs-vite/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"projectType": "library",
"targets": {
"build": {}
"build": {},
"check": {}
}
}
8 changes: 0 additions & 8 deletions code/frameworks/nextjs-vite/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ import type { ReactPreview } from '@storybook/react';
import { __definePreview } from '@storybook/react';
import type { ReactTypes } from '@storybook/react';

import type vitePluginStorybookNextJs from 'vite-plugin-storybook-nextjs';

import * as nextPreview from './preview';
import type { NextJsTypes } from './types';

Expand All @@ -15,12 +13,6 @@ export * from '@storybook/react';
export * from './portable-stories';
export * from './types';

// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
declare module '@storybook/nextjs-vite/vite-plugin' {
export const storybookNextJsPlugin: typeof vitePluginStorybookNextJs;
}

export function definePreview<Addons extends PreviewAddon<never>[]>(
preview: { addons?: Addons } & ProjectAnnotations<ReactTypes & NextJsTypes & InferTypes<Addons>>
): NextPreview<InferTypes<Addons>> {
Expand Down
4 changes: 2 additions & 2 deletions code/frameworks/nextjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@
"!src/**/*"
],
"scripts": {
"check": "jiti ../../../scripts/prepare/check.ts",
"prep": "jiti ../../../scripts/prepare/bundle.ts"
"prep": "jiti ../../../scripts/prepare/bundle.ts",
"typecheck": "jiti ../../../scripts/prepare/check.ts"
},
"dependencies": {
"@babel/core": "^7.24.4",
Expand Down
3 changes: 2 additions & 1 deletion code/frameworks/nextjs/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"projectType": "library",
"targets": {
"build": {}
"build": {},
"check": {}
}
}
4 changes: 2 additions & 2 deletions code/frameworks/preact-vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@
"!src/**/*"
],
"scripts": {
"check": "jiti ../../../scripts/prepare/check.ts",
"prep": "jiti ../../../scripts/prepare/bundle.ts"
"prep": "jiti ../../../scripts/prepare/bundle.ts",
"typecheck": "jiti ../../../scripts/prepare/check.ts"
},
"dependencies": {
"@storybook/builder-vite": "workspace:*",
Expand Down
3 changes: 2 additions & 1 deletion code/frameworks/preact-vite/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"projectType": "library",
"targets": {
"build": {}
"build": {},
"check": {}
}
}
4 changes: 2 additions & 2 deletions code/frameworks/react-native-web-vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@
"!src/**/*"
],
"scripts": {
"check": "jiti ../../../scripts/prepare/check.ts",
"prep": "jiti ../../../scripts/prepare/bundle.ts"
"prep": "jiti ../../../scripts/prepare/bundle.ts",
"typecheck": "jiti ../../../scripts/prepare/check.ts"
},
"dependencies": {
"@bunchtogether/vite-plugin-flow": "^1.0.2",
Expand Down
3 changes: 2 additions & 1 deletion code/frameworks/react-native-web-vite/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"projectType": "library",
"targets": {
"build": {}
"build": {},
"check": {}
}
}
4 changes: 2 additions & 2 deletions code/frameworks/react-vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@
"!src/**/*"
],
"scripts": {
"check": "jiti ../../../scripts/prepare/check.ts",
"prep": "jiti ../../../scripts/prepare/bundle.ts"
"prep": "jiti ../../../scripts/prepare/bundle.ts",
"typecheck": "jiti ../../../scripts/prepare/check.ts"
},
"dependencies": {
"@joshwooding/vite-plugin-react-docgen-typescript": "0.6.0",
Expand Down
3 changes: 2 additions & 1 deletion code/frameworks/react-vite/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"projectType": "library",
"targets": {
"build": {}
"build": {},
"check": {}
}
}
4 changes: 2 additions & 2 deletions code/frameworks/react-webpack5/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@
"!src/**/*"
],
"scripts": {
"check": "jiti ../../../scripts/prepare/check.ts",
"prep": "jiti ../../../scripts/prepare/bundle.ts"
"prep": "jiti ../../../scripts/prepare/bundle.ts",
"typecheck": "jiti ../../../scripts/prepare/check.ts"
},
"dependencies": {
"@storybook/builder-webpack5": "workspace:*",
Expand Down
Loading