Skip to content

Add 'waitUntil' option to puppeteer of storyshots #3156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2018
Merged

Add 'waitUntil' option to puppeteer of storyshots #3156

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
329507f
Add 'waitUntil' option to puppeteer of storyshots
markelog Mar 6, 2018
c0c6685
Merge branch 'master' into goto
ndelangen Mar 9, 2018
51b6a61
Merge branch 'master' into goto
Hypnosphi Mar 12, 2018
a658719
Merge branch 'master' into goto
Hypnosphi Mar 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addons/storyshots/src/test-body-image-snapshot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const imageSnapshot = ({

expect.assertions(1);
return page
.goto(url)
.goto(url, {"waitUntil" : "networkidle0"})
.catch(e => {
logger.error(
`ERROR WHILE CONNECTING TO ${url}, did you start or build the storybook first ? A storybook instance should be running or a static version should be built when using image snapshot feature.`,
Expand Down