Skip to content

Telemetry: Use version from our package.json for storybookVersion #31577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shilman merged 7 commits into from
May 28, 2025
Merged

Telemetry: Use version from our package.json for storybookVersion #31577

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c564f4a
Use actual version from our `package.json` when reporting cli/sb vers…
tmeasday May 19, 2025
73ca5c4
Check for SB version in event metadata
tmeasday May 19, 2025
70770ef
storybookVersion is on metadata
tmeasday May 19, 2025
90a17ae
Boot event has no metadata
tmeasday May 19, 2025
bd24b0b
Move `storybookVersion` to context
tmeasday May 19, 2025
14eaab7
Also add `metadata.storybookVersion` back
tmeasday May 28, 2025
3de59b7
Merge branch 'next' into tom/refactor-storybookId-in-telemetry
tmeasday May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Boot event has no metadata
  • Loading branch information
@tmeasday
tmeasday committed May 27, 2025
commit 90a17aed10c68feeba2b5d41a86b61cee769a734
10 changes: 6 additions & 4 deletions scripts/event-log-checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,12 @@ async function run() {

const [bootEvent, mainEvent] = events;

test(`both events should have storybookVersion in metadata`, () => {
const cliVersion = versions.storybook;
assert.equal(bootEvent.metadata.storybookVersion, cliVersion);
assert.equal(mainEvent.metadata.storybookVersion, cliVersion);
test('boot event should have cliVersion in context', () => {
assert.equal(bootEvent.context.cliVersion, versions.storybook);
});

test(`main event should have storybookVersion in metadata`, () => {
assert.equal(mainEvent.metadata.storybookVersion, versions.storybook);
});

test(`Should log a boot event with a payload of type ${eventType}`, () => {
Expand Down