Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use actual version from our package.json when reporting cli/sb vers…
…ion in telemetry metadata
  • Loading branch information
tmeasday committed May 27, 2025
commit c564f4a3bec160fbbcc7c1c8efe2fbe83b3efdb6
4 changes: 2 additions & 2 deletions code/core/src/cli/bin/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { getEnvConfig, parseList, versions } from 'storybook/internal/common';
import { getEnvConfig, parseList } from 'storybook/internal/common';
import { logger } from 'storybook/internal/node-logger';
import { addToGlobalContext } from 'storybook/internal/telemetry';

Expand All @@ -14,7 +14,7 @@ import { buildIndex as index } from '../buildIndex';
import { dev } from '../dev';
import { globalSettings } from '../globalSettings';

addToGlobalContext('cliVersion', versions.storybook);
addToGlobalContext('cliVersion', version);

const consoleLogger = console;

Expand Down
4 changes: 2 additions & 2 deletions code/core/src/telemetry/storybook-metadata.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import type { PackageJson, StorybookConfig } from 'storybook/internal/types';
import { findPackage, findPackagePath } from 'fd-package-json';
import { detect } from 'package-manager-detector';

import { version } from '../../package.json';
import { globalSettings } from '../cli/globalSettings';
import { getApplicationFileCount } from './get-application-file-count';
import { getChromaticVersionSpecifier } from './get-chromatic-version';
Expand Down Expand Up @@ -227,7 +228,6 @@ export const computeStorybookMetadata = async ({
// gracefully handle error, as it's not critical information and AST parsing can cause trouble
}

const storybookVersion = storybookPackages[storybookInfo.frameworkPackage]?.version;
const portableStoriesFileCount = await getPortableStoriesFileCount();
const applicationFileCount = await getApplicationFileCount(dirname(packageJsonPath));

Expand All @@ -236,7 +236,7 @@ export const computeStorybookMetadata = async ({
...frameworkInfo,
portableStoriesFileCount,
applicationFileCount,
storybookVersion,
storybookVersion: version,
storybookVersionSpecifier: storybookInfo.version,
language,
storybookPackages,
Expand Down