Docs: Testing section improvements #31594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add "Automate with CI" sections to Interaction and Accessibility testing guides - Add "Querying within shadow DOM" section to Interaction testing guide
kylegach
added
documentation
patch:yes
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit ceefaf2.
☁️ Nx Cloud last updated this comment at |
jonniebigodes
approved these changes
May 30, 2025
Contributor
jonniebigodes
left a comment
jonniebigodes
left a comment
There was a problem hiding this comment.
Thanks for taking the time to adjust the documentation. I appreciate it 🙏 ! I left a couple of small items for you to look into when you can. Nothing major or blocking this from getting merged and released.
Approving to unblock you.
Co-authored-by: jonniebigodes <[email protected]>
This was referenced May 30, 2025
Merged
shilman
pushed a commit
that referenced
this pull request
May 31, 2025
Docs: Testing section improvements (cherry picked from commit 9d8c255)
github-actions
bot
added
the
patch:done
12 tasks
ndelangen
removed
the
patch:yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Checklist for Contributors
Testing
Manual testing
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.Greptile Summary
Enhanced testing documentation with new sections on CI automation for accessibility and interaction testing, plus shadow DOM querying for web components.
docs/writing-tests/accessibility-testing.mdxanddocs/writing-tests/interaction-testing.mdxdocs/writing-tests/interaction-testing.mdxdocs/_snippets/shadow-dom-testing-library-in-preview.mdshowing TypeScript/JavaScript setup for shadow DOM testingdocs/_snippets/shadow-dom-testing-library-in-story.mdwith practical examples of shadow DOM element queries