Release: Prerelease 9.1.0-alpha.4 #31725

github-actions · 2025-06-10T09:58:54Z

This is an automated pull request that bumps the version from 9.1.0-alpha.3 to 9.1.0-alpha.4.
Once this pull request is merged, it will trigger a new release of version 9.1.0-alpha.4.
If you're not a core maintainer with permissions to release you can ignore this pull request.

To do

Before merging the PR, there are a few QA steps to go through:

Add the "freeze" label to this PR, to ensure it doesn't get automatically forced pushed by new changes.
Add the "ci:daily" label to this PR, to trigger the full test suite to run on this PR.

And for each change below:

Ensure the change is appropriate for the version bump. E.g. patch release should only contain patches, not new or de-stabilizing features. If a change is not appropriate, revert the PR.
Ensure the PR is labeled correctly with one of: "BREAKING CHANGE", "feature request", "bug", "maintenance", "dependencies", "documentation", "build", "unknown".
Ensure the PR title is correct, and follows the format "[Area]: [Summary]", e.g. "React: Fix hooks in CSF3 render functions". If it is not correct, change the title in the PR.
- Areas include: React, Vue, Core, Docs, Controls, etc.
- First word of summary indicates the type: “Add”, “Fix”, “Upgrade”, etc.
- The entire title should fit on a line

This is a list of all the PRs merged and commits pushed directly to next, that will be part of this release:

✨ Feature Request: CSF Factories: Add parameters/globals types, extend API, portable stories #30601
📝 Documentation: Docs: Point CSF Factories docs at RFC #31713 (will also be patched)

If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.

Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.

When everything above is done:

Merge this PR
Follow the run of the publish action

Generated changelog

9.1.0-alpha.4

CSF Factories: Add parameters/globals types, extend API, portable stories - #30601, thanks @kasperpeulen!

Greptile Summary

Introduces CSF (Component Story Format) Factories with significant type system improvements and story composition features.

Replaced definePreview with type-safe definePreviewAddon across all core addons for better TypeScript inference
Added new TypeScript parameter/globals type system for standardized addon configuration
Introduced .extend API enabling story composition and inheritance
Added configDir parameter to addon synchronization for improved path resolution
Simplified documentation by pointing users to RFC during experimental phase

# Conflicts: # code/core/src/csf/csf-factories.ts

# Conflicts: # code/addons/a11y/src/index.ts # code/addons/a11y/src/types.ts # code/addons/actions/src/index.ts # code/addons/backgrounds/src/index.ts # code/addons/controls/src/index.ts # code/addons/docs/src/index.ts # code/addons/essentials/src/index.ts # code/addons/essentials/src/types.ts # code/addons/highlight/src/index.ts # code/addons/highlight/src/types.ts # code/addons/interactions/src/types.ts # code/addons/links/src/index.ts # code/addons/measure/src/index.ts # code/addons/outline/src/index.ts # code/addons/pseudo-states/src/index.ts # code/addons/test/src/index.ts # code/addons/test/src/types.ts # code/addons/themes/src/index.ts # code/addons/viewport/src/index.ts # code/core/src/backgrounds/types.ts # code/core/src/csf/csf-factories.ts # code/core/src/viewport/types.ts # code/frameworks/nextjs-vite/src/index.ts # code/frameworks/nextjs/src/index.ts # code/renderers/react/src/csf-factories.test.tsx # code/renderers/react/src/preview.tsx

# Conflicts: # code/addons/vitest/src/types.ts

…sf-parameters

…er/csf-parameters

Docs: Point CSF Factories docs at RFC

# Conflicts: # docs/api/csf/csf-factories.mdx

CSF Factories: Add parameters/globals types, `extend` API, portable stories

greptile-apps

_{80 files reviewed, 8 comments}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-06-10T10:02:09Z

code/core/src/preview-api/modules/preview-web/render/MdxDocsRender.ts

    const docsContext = this.docsContext(renderStoryToElement);

-    const { docs } = this.store.projectAnnotations.parameters || {};
+    const { docs } = this.store.projectAnnotations.parameters ?? ({} as { docs: any });


style: Type assertion to { docs: any } is overly permissive and could hide legitimate type errors. Consider using a more specific type or handling undefined explicitly.

greptile-apps · 2025-06-10T10:02:12Z

code/frameworks/nextjs/src/index.ts

+export function definePreview<Addons extends PreviewAddon<never>[]>(
+  preview: { addons?: Addons } & ProjectAnnotations<ReactTypes & NextJsTypes & InferTypes<Addons>>
+): NextPreview<InferTypes<Addons>> {
+  // @ts-expect-error hard


logic: The // @ts-expect-error hard comment should be more descriptive about what type error is being suppressed and why it's necessary

greptile-apps · 2025-06-10T10:02:12Z

code/frameworks/nextjs/src/index.ts

 // @ts-expect-error (double exports)
 export * from './portable-stories';


style: Consider moving portable-stories export to a separate entry point to avoid the double export ts-expect-error

greptile-apps · 2025-06-10T10:02:19Z

code/renderers/react/src/preview.tsx

-export interface ReactStory extends Story<ReactRenderer> {}
+export interface ReactStory<T extends ReactTypes, TInput extends StoryAnnotations<T, T['args']>>
+  extends Story<T, TInput> {
+  Component: ComponentType<Partial<T['args']>>;


style: Consider making Component readonly to prevent accidental overwrites

greptile-apps · 2025-06-10T10:02:20Z

code/core/src/viewport/components/Tool.tsx

                id: k,
                title: value.name,
-                icon: iconsMap[value.type],
+                icon: iconsMap[value.type!],


style: Type assertion unnecessary here - consider making viewport.type non-optional or handling undefined case explicitly

greptile-apps · 2025-06-10T10:02:21Z

code/core/src/csf/csf-factories.ts

+    get play() {
+      return input.play ?? meta.input?.play ?? (async () => {});
+    },


style: Default empty async function should be defined as constant to avoid recreating on each get.

greptile-apps · 2025-06-10T10:02:23Z

code/renderers/react/src/__test__/portable-stories-factory.test.tsx

+import {
+  CSF2StoryWithLocale,
+  CSF3Button,
+  CSF3ButtonWithRender,
+  CSF3InputFieldFilled,
+  CSF3Primary,
+  MountInPlayFunction,
+  MountInPlayFunctionThrow,
+} from './Button.csf4.stories';
+import { CSF2Secondary, HooksStory } from './Button.csf4.stories';


style: Consider consolidating the two imports from Button.csf4.stories into a single import statement for better maintainability

Suggested change

import {

CSF2StoryWithLocale,

CSF3Button,

CSF3ButtonWithRender,

CSF3InputFieldFilled,

CSF3Primary,

MountInPlayFunction,

MountInPlayFunctionThrow,

} from './Button.csf4.stories';

import { CSF2Secondary, HooksStory } from './Button.csf4.stories';

import {

CSF2StoryWithLocale,

CSF3Button,

CSF3ButtonWithRender,

CSF3InputFieldFilled,

CSF3Primary,

MountInPlayFunction,

MountInPlayFunctionThrow,

CSF2Secondary,

HooksStory,

} from './Button.csf4.stories';

greptile-apps · 2025-06-10T10:02:36Z

code/core/src/common/utils/sync-main-preview-addons.ts

+  previewConfigPath: string,
+  configDir: string
+) {
  const previewConfig = await readConfig(previewConfigPath!);


style: Unnecessary non-null assertion operator - previewConfigPath is already required by function signature

Suggested change

const previewConfig = await readConfig(previewConfigPath!);

const previewConfig = await readConfig(previewConfigPath);

kasperpeulen added 30 commits February 12, 2025 13:58

WIP: Add support for parameters

57c2c8c

Merge remote-tracking branch 'origin/next' into kasper/csf-parameters

cf87f2a

# Conflicts: # code/core/src/csf/csf-factories.ts

Fix

59b9d5d

Rollback preview changes

526ce10

Fix tests

07fbadc

Pass parameters to story and meta

ec29949

Fix type tests

238df1b

Don't export in addon-outline

8050a06

Don't export in addon-backgrounds

f7a85a7

Get all addons in shape

793a49b

Fix next as well

5af7f47

Fix check

70c0641

Just test the parameters

9eb7abe

Fix

9733393

Merge remote-tracking branch 'origin/next' into kasper/csf-parameters

e77a51f

# Conflicts: # code/addons/vitest/src/types.ts

Remove shared csf4 file

1e25c44

Restructure core annotations in csf export

e8fbce4

Fix check

bfc9665

Add test of mrginglymus

0a804a5

Merge remote-tracking branch 'refs/remotes/origin/next' into kasper/c…

9cb16c1

…sf-parameters

Fix

a402c19

Merge branch 'next' into kasper/csf-parameters

1401cce

Fix composed

82e2e1b

Fix input.args type

4f8d020

Fix core types

d13935a

Fix core parameter types

4f06e56

Add globals

f090c08

Fix

9f2b655

Fix

fa988c0

kasperpeulen and others added 23 commits June 5, 2025 15:45

Fix react parameter types

276ddde

Fix nextjs-vite types

e20b842

Always provide configDir

411c198

Fix tests

4f24c5e

Fix types

be60407

Fix next types

66d8f42

Remove old definePreview

1bd4318

Merge branch 'next' into kasper/csf-parameters

2b9a7be

Merge branch 'next' into kasper/csf-parameters

111e2b4

Implement composed for stories

d524e95

Merge remote-tracking branch 'origin/kasper/csf-parameters' into kasp…

a1170d7

…er/csf-parameters

Refactor and explain

da74e17

Remove csf factory docs

bdc40b3

Fix react addon inference

7dd5736

Update CHANGELOG.md for v9.0.6 [skip ci]

99cb74a

Docs: Point CSF Factories docs at RFC

d50fb31

Add reference to csf-2-to-3 codemod

8242723

Merge pull request #31713 from storybookjs/docs-csf-factories-ref-rfc

1d1f8e0

Docs: Point CSF Factories docs at RFC

Address feedback

9c22424

Merge remote-tracking branch 'origin/next' into kasper/csf-parameters

9ab9f8b

# Conflicts: # docs/api/csf/csf-factories.mdx

Roll back docs changes

d70f67e

Merge pull request #30601 from storybookjs/kasper/csf-parameters

fc8890b

CSF Factories: Add parameters/globals types, `extend` API, portable stories

Write changelog for 9.1.0-alpha.4 [skip ci]

f253735

github-actions bot added the release For PRs that trigger new releases. Automated label Jun 10, 2025

github-actions bot requested review from jonniebigodes and kylegach as code owners June 10, 2025 09:58

github-actions bot added the release For PRs that trigger new releases. Automated label Jun 10, 2025

kasperpeulen merged commit 19614aa into next-release Jun 10, 2025

kasperpeulen deleted the version-non-patch-from-9.1.0-alpha.3 branch June 10, 2025 10:00

greptile-apps bot reviewed Jun 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Release: Prerelease 9.1.0-alpha.4 #31725

Release: Prerelease 9.1.0-alpha.4 #31725

Uh oh!

github-actions bot commented Jun 10, 2025 •

edited by greptile-apps bot

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Jun 10, 2025

Uh oh!

greptile-apps bot Jun 10, 2025

Uh oh!

greptile-apps bot Jun 10, 2025

Uh oh!

greptile-apps bot Jun 10, 2025

Uh oh!

greptile-apps bot Jun 10, 2025

Uh oh!

greptile-apps bot Jun 10, 2025

Uh oh!

greptile-apps bot Jun 10, 2025

Uh oh!

greptile-apps bot Jun 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		// @ts-expect-error (double exports)
		export * from './portable-stories';

	const previewConfig = await readConfig(previewConfigPath!);
	const previewConfig = await readConfig(previewConfigPath);

Uh oh!

Release: Prerelease 9.1.0-alpha.4 #31725

Release: Prerelease 9.1.0-alpha.4 #31725

Uh oh!

Conversation

github-actions bot commented Jun 10, 2025 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

To do

Generated changelog

9.1.0-alpha.4

Greptile Summary

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Jun 10, 2025 •

edited by greptile-apps bot

Loading