Refactor: Update isCI usage to function calls across multiple files

- Changed instances of `isCI` to `isCI()` in various files to ensure consistent function usage.
- Updated related logic in `postinstall-logger.ts`, `postinstall.ts`, `withTelemetry.ts`, and others to reflect this change.
- Enhanced test coverage for `isCI` behavior in `storybook-metadata.test.ts`.

code/addons/vitest/src/postinstall-logger.ts

@@ -1,7 +1,7 @@
 import { isCI } from 'storybook/internal/common';
 import { colors, logger } from 'storybook/internal/node-logger';
 
-const fancy = process.platform !== 'win32' || isCI || process.env.TERM === 'xterm-256color';
+const fancy = process.platform !== 'win32' || isCI() || process.env.TERM === 'xterm-256color';
 
 export const step = colors.gray('›');
 export const info = colors.blue(fancy ? 'ℹ' : 'i');

code/addons/vitest/src/postinstall.ts

@@ -80,7 +80,7 @@ export default async function postInstall(options: PostinstallOptions) {
 
   const hasCustomWebpackConfig = !!config.getFieldNode(['webpackFinal']);
 
-  const isInteractive = process.stdout.isTTY && !isCI;
+  const isInteractive = process.stdout.isTTY && !isCI();
 
   if (info.frameworkPackageName === '@storybook/nextjs' && !hasCustomWebpackConfig) {
     const out =

code/core/src/common/utils/envs.ts

@@ -87,4 +87,6 @@ export const optionalEnvToBoolean = (input: string | undefined): boolean | undef
  * Doing Boolean(process.env.CI) or !process.env.CI is not enough, because users might set CI=false
  * or CI=0, which would be truthy, and thus return true in those cases.
  */
-export const isCI = optionalEnvToBoolean(process.env.CI);
+export function isCI(): boolean | undefined {
+  return optionalEnvToBoolean(process.env.CI);
+}

code/core/src/core-server/utils/server-address.test.ts

@@ -6,6 +6,7 @@ import { getServerAddresses, getServerChannelUrl, getServerPort } from './server
 
 vi.mock('node:os', () => ({
   default: { release: () => '' },
+  platform: 'darwin',
   constants: {
     signals: {},
   },

code/core/src/core-server/withTelemetry.ts

@@ -14,7 +14,7 @@ type TelemetryOptions = {
 };
 
 const promptCrashReports = async () => {
-  if (isCI || !process.stdout.isTTY) {
+  if (isCI() || !process.stdout.isTTY) {
     return undefined;
   }
 

code/core/src/node-logger/logger/log-tracker.ts

@@ -99,7 +99,7 @@ class LogTracker {
     await fs.writeFile(filePath, logContent, 'utf-8');
     this.#logs = [];
 
-    return isCI ? filePath : path.relative(process.cwd(), filePath);
+    return isCI() ? filePath : path.relative(process.cwd(), filePath);
   }
 }
 

code/core/src/telemetry/storybook-metadata.test.ts

@@ -3,11 +3,12 @@ import path from 'node:path';
 import type { MockInstance } from 'vitest';
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 
-import { getStorybookInfo } from 'storybook/internal/common';
+import { getStorybookInfo, isCI } from 'storybook/internal/common';
 import type { PackageJson, StorybookConfig } from 'storybook/internal/types';
 
 import { detect } from 'package-manager-detector';
 
+import { type Settings, globalSettings } from '../cli/globalSettings';
 import { getMonorepoType } from '../telemetry/get-monorepo-type';
 import {
   getActualPackageJson,
@@ -16,6 +17,7 @@ import {
 } from './package-json';
 import { computeStorybookMetadata, metaFrameworks, sanitizeAddonName } from './storybook-metadata';
 
+vi.mock(import('../cli/globalSettings'), { spy: true });
 vi.mock(import('./package-json'), { spy: true });
 vi.mock(import('./get-monorepo-type'), { spy: true });
 vi.mock(import('package-manager-detector'), { spy: true });
@@ -442,14 +444,38 @@ describe('storybook-metadata', () => {
     );
 
     it('should detect userSince info', async () => {
+      vi.mocked(isCI).mockImplementation(() => false);
+      vi.mocked(globalSettings).mockResolvedValue({
+        value: {
+          userSince: 1717334400000,
+        },
+      } as Settings);
+
+      const res = await computeStorybookMetadata({
+        configDir: '.storybook',
+        packageJson: packageJsonMock,
+        packageJsonPath,
+        mainConfig: mainJsMock,
+      });
+
+      expect(globalSettings).toHaveBeenCalled();
+
+      expect(res.userSince).toEqual(1717334400000);
+    });
+
+    it('should not detect userSince info in CI', async () => {
+      vi.mocked(isCI).mockImplementation(() => true);
+      vi.mocked(globalSettings).mockResolvedValue({} as Settings);
+
       const res = await computeStorybookMetadata({
         configDir: '.storybook',
         packageJson: packageJsonMock,
         packageJsonPath,
         mainConfig: mainJsMock,
       });
 
-      expect(res.userSince).toBeDefined();
+      expect(globalSettings).not.toHaveBeenCalled();
+      expect(res.userSince).not.toBeDefined();
     });
   });
 });

code/core/src/telemetry/storybook-metadata.ts

@@ -57,7 +57,7 @@ export const computeStorybookMetadata = async ({
   mainConfig?: StorybookConfig & Record<string, any>;
   configDir: string;
 }): Promise<StorybookMetadata> => {
-  const settings = isCI ? undefined : await globalSettings();
+  const settings = isCI() ? undefined : await globalSettings();
   const metadata: Partial<StorybookMetadata> = {
     generatedAt: new Date().getTime(),
     userSince: settings?.value.userSince,

code/core/src/telemetry/telemetry.ts

@@ -47,7 +47,7 @@ const getOperatingSystem = (): 'Windows' | 'macOS' | 'Linux' | `Other: ${string}
 // by the app. currently:
 // - cliVersion
 const globalContext = {
-  inCI: isCI,
+  inCI: isCI(),
   isTTY: process.stdout.isTTY,
   platform: getOperatingSystem(),
   nodeVersion: process.versions.node,

code/lib/cli-storybook/src/bin/index.ts

@@ -89,7 +89,7 @@ command('init')
   .option(
     '--dev',
     'Launch the development server after completing initialization. Enabled by default (default: true)',
-    !isCI && !optionalEnvToBoolean(process.env.IN_STORYBOOK_SANDBOX)
+    !isCI() && !optionalEnvToBoolean(process.env.IN_STORYBOOK_SANDBOX)
   )
   .option(
     '--no-dev',

code/lib/cli-storybook/src/sandbox.ts

@@ -226,7 +226,7 @@ export const sandbox = async ({
         // @ts-ignore-error (no types for this)
         const { initiate } = await import('create-storybook');
         await initiate({
-          dev: isCI && !optionalEnvToBoolean(process.env.IN_STORYBOOK_SANDBOX),
+          dev: isCI() && !optionalEnvToBoolean(process.env.IN_STORYBOOK_SANDBOX),
           ...options,
           features: ['docs', 'test'],
         });

code/lib/create-storybook/src/bin/index.ts

@@ -51,8 +51,10 @@ const createStorybookProgram = program
 
 createStorybookProgram
   .action(async (options) => {
+    const isNeitherCiNorSandbox =
+      !isCI() && !optionalEnvToBoolean(process.env.IN_STORYBOOK_SANDBOX);
     options.debug = options.debug ?? false;
-    options.dev = options.dev ?? (isCI && !optionalEnvToBoolean(process.env.IN_STORYBOOK_SANDBOX));
+    options.dev = options.dev ?? isNeitherCiNorSandbox;
 
     await initiate(options as CommandOptions).catch(() => process.exit(1));
   })

code/lib/create-storybook/src/generators/baseGenerator.ts

@@ -354,7 +354,7 @@ export async function baseGenerator(
   }).start();
 
   try {
-    if (!isCI) {
+    if (!isCI()) {
       const { hasEslint, isStorybookPluginInstalled, isFlatConfig, eslintConfigFile } =
         // TODO: Investigate why packageManager type does not match on CI
         await extractEslintInfo(packageManager as any);

code/lib/create-storybook/src/initiate.ts

@@ -442,7 +442,7 @@ export async function doInitiate(options: CommandOptions): Promise<
     )
   );
 
-  const isInteractive = process.stdout.isTTY && !isCI;
+  const isInteractive = process.stdout.isTTY && !isCI();
 
   const settings = await globalSettings();
   const promptOptions = {