Skip to content

Conversation

@ryomaejii
Copy link
Contributor

@ryomaejii ryomaejii commented Jun 17, 2025

issue: #31800

This PR fixes incorrect homepage and directory paths in package.json files for both CLI packages.

Changes

@storybook/cli package

  • Update homepage URL from code/lib/cli to code/lib/cli-storybook
  • Update repository directory from code/lib/cli to code/lib/cli-storybook

sb package (sub CLI)

  • Update homepage URL from code/lib/cli to code/lib/cli-sub
  • Update repository directory from code/lib/cli to code/lib/cli-sub

How to test

  • No functional changes, only metadata updates in package.json files

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@ryomaejii ryomaejii changed the title fix(cli): update package.json homepage and directory paths fix(cli): update paths from /cli to /cli-storybook in cli-storybook package.json Jun 17, 2025
@ryomaejii ryomaejii changed the title fix(cli): update paths from /cli to /cli-storybook in cli-storybook package.json fix(cli): update paths from /cli to /cli-storybook in cli-storybook package.json Jun 17, 2025
@ryomaejii ryomaejii changed the title fix(cli): update paths from /cli to /cli-storybook in cli-storybook package.json [Documentation]: update paths from /cli to /cli-storybook in cli-storybook package.json Jun 17, 2025
@ryomaejii ryomaejii changed the title [Documentation]: update paths from /cli to /cli-storybook in cli-storybook package.json Docs: update paths from /cli to /cli-storybook in cli-storybook package.json Jun 17, 2025
Copy link
Member

@indigolain indigolain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!
I've noticed that some of the urls and paths may not be pointing to the intended ones.
Could you check them?

ryomaejii and others added 2 commits June 18, 2025 11:31
@ryomaejii ryomaejii requested a review from indigolain June 18, 2025 02:31
@nx-cloud
Copy link

nx-cloud bot commented Jun 18, 2025

View your CI Pipeline Execution ↗ for commit 7e91f9e.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 12s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-02 13:34:11 UTC

@valentinpalkovic valentinpalkovic self-assigned this Jun 23, 2025
@valentinpalkovic valentinpalkovic added cleanup Minor cleanup style change that won't show up in release changelog ci:normal labels Jun 23, 2025
@valentinpalkovic
Copy link
Contributor

Can you please resolve the merge conflicts?

@ryomaejii
Copy link
Contributor Author

@valentinpalkovic
I resolved the merge conflicts!

@valentinpalkovic
Copy link
Contributor

LGTM!

@valentinpalkovic valentinpalkovic changed the title Docs: update paths from /cli to /cli-storybook in cli-storybook package.json Docs: Update paths from /cli to /cli-storybook in cli-storybook package.json Jul 2, 2025
@storybook-app-bot
Copy link

storybook-app-bot bot commented Jul 2, 2025

Package Benchmarks

Commit: 720324e, ran on 11 July 2025 at 04:41:27 UTC

No significant changes detected, all good. 👏

@github-actions github-actions bot added the Stale label Jul 25, 2025
@github-actions github-actions bot added the Stale label Aug 11, 2025
@valentinpalkovic valentinpalkovic merged commit dfa44c7 into storybookjs:next Aug 11, 2025
0 of 3 checks passed
@github-actions github-actions bot mentioned this pull request Aug 11, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:normal cleanup Minor cleanup style change that won't show up in release changelog needs triage Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants