Skip to content

Conversation

@messenjer
Copy link
Contributor

@messenjer messenjer commented Jun 18, 2025

Closes #31815

What I did

Add missing extends: true to inherit root config, and set name: 'storybook' in the project config of vitest.config.ts. for react , vue and svelte example

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Updates Vitest configuration documentation to include essential project configuration properties across React, Vue, and Svelte examples.

  • Adds extends: true to properly inherit root configuration settings
  • Sets name: 'storybook' for clear project identification in test outputs
  • Updates documentation snippets in docs/_snippets/vitest-plugin-vitest-config.md for all three frameworks
  • Improves test organization and configuration inheritance patterns

…ect config

Add missing `extends: true` to inherit root config, and set `name: 'storybook'` in the project config of vitest.config.ts. for react , vue and svelte example
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@nx-cloud
Copy link

nx-cloud bot commented Jun 18, 2025

View your CI Pipeline Execution ↗ for commit 281a35e.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 14s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-24 07:02:50 UTC

@valentinpalkovic valentinpalkovic added documentation ci:docs Run the CI jobs for documentation checks only. addon: vitest patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 23, 2025
@ghengeveld ghengeveld moved this to Empathy Queue (prioritized) in Core Team Projects Jun 23, 2025
@ghengeveld ghengeveld changed the title docs(storybook): add missing extends: true in vitest.config.ts project config Docs: Add missing extends: true in vitest.config.ts snippets Jun 23, 2025
@ghengeveld ghengeveld moved this from Empathy Queue (prioritized) to In Progress in Core Team Projects Jun 24, 2025
@ghengeveld ghengeveld merged commit 7d277a6 into storybookjs:next Jun 24, 2025
6 of 7 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Core Team Projects Jun 24, 2025
ghengeveld added a commit that referenced this pull request Jun 24, 2025
Docs: Add missing `extends: true` in `vitest.config.ts` snippets
(cherry picked from commit 7d277a6)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 24, 2025
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addon: vitest ci:docs Run the CI jobs for documentation checks only. documentation patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Documentation]: Example vitest.config.ts in docs does not work with Storybook 9.0.12 and Vitest 3.2

5 participants