Skip to content

CI: Reevaluate E2E locator with each assertion #31845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghengeveld merged 8 commits into from
Jul 7, 2025
Merged

CI: Reevaluate E2E locator with each assertion #31845

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dde1884
Allow more time for Vitest to boot and check for Starting text as a s…
ghengeveld Jun 23, 2025
914c1d0
Piping stdout isn't helpful, just noisy
ghengeveld Jun 23, 2025
dc64884
Check description text before button state
ghengeveld Jun 23, 2025
606a315
Reevaluate locator for each assertion
ghengeveld Jul 4, 2025
1d55ded
Merge branch 'next' into fix-component-testing-e2e-flake
ghengeveld Jul 4, 2025
9b77c8f
Group assertions which happen simultaneously
ghengeveld Jul 7, 2025
6282321
It can take a little while for Vitest to start
ghengeveld Jul 7, 2025
04a8a4b
Add clarifying comment
ghengeveld Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions test-storybooks/portable-stories-kitchen-sink/react/e2e-tests/component-testing.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,24 +205,25 @@ test.describe("component testing", () => {
"Run component tests"
);

const testingModuleDescription = await page.locator(
"#testing-module-description"
);

const runTestsButton = await page.getByLabel("Start test run");
const watchModeButton = await page.getByLabel("Enable watch mode");
await expect(runTestsButton).toBeEnabled();
await expect(watchModeButton).toBeEnabled();

await runTestsButton.click();
await expect(watchModeButton).toBeDisabled();

await expect(testingModuleDescription).toContainText("Testing");
await expect(page.locator("#testing-module-description")).toHaveText(
/Starting/
);
await expect(page.locator("#testing-module-description")).toHaveText(
/Testing/
);

// Wait for test results to appear
await expect(testingModuleDescription).toHaveText(/Ran \d+ tests/, {
timeout: 30000,
});
await expect(page.locator("#testing-module-description")).toHaveText(
/Ran \d+ tests/,
{ timeout: 30000 }
);

await expect(runTestsButton).toBeEnabled();
await expect(watchModeButton).toBeEnabled();
Expand Down
2 changes: 0 additions & 2 deletions test-storybooks/portable-stories-kitchen-sink/react/playwright-e2e.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,5 @@ export default defineConfig({
command: "yarn storybook",
url: "http://127.0.0.1:6006",
reuseExistingServer: true,
stdout: "pipe",
stderr: "pipe",
},
});