Skip to content

Controls: Allow primitive values of ReactNode argType #31931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndelangen merged 13 commits into from
Sep 23, 2025
Merged

Controls: Allow primitive values of ReactNode argType #31931

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7f70c34
fix: allow primitive URL arg value for ReactNode argType
alexey-kozlenkov Jul 2, 2025
e546bff
(chore) Modify case to avoid fallthrough and always return
alexey-kozlenkov Jul 2, 2025
320d25c
Update args.ts
alexey-kozlenkov Aug 28, 2025
f00370a
(test) Add test case with non-primitive arg value
alexey-kozlenkov Aug 28, 2025
2e7d8f4
(chore) Better test description
alexey-kozlenkov Aug 28, 2025
9a3cc98
Merge branch 'next' into next
alexey-kozlenkov Sep 3, 2025
26554cf
Merge branch 'next' into next
alexey-kozlenkov Sep 12, 2025
5c7fab6
Merge branch 'next' into next
alexey-kozlenkov Sep 16, 2025
7ad81bd
Merge branch 'next' into next
alexey-kozlenkov Sep 17, 2025
cd1be14
(lint) Wrap case into a block
alexey-kozlenkov Sep 23, 2025
5c2e33f
(chore) Fix indentation
alexey-kozlenkov Sep 23, 2025
c9d17d7
Merge branch 'next' into next
ndelangen Sep 23, 2025
f863ac3
(chore) Fix linter
alexey-kozlenkov Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
(chore) Better test description
  • Loading branch information
@alexey-kozlenkov
alexey-kozlenkov committed Aug 28, 2025
commit 2e7d8f42f8380ce6358bb0eb330d9b28659b59da
2 changes: 1 addition & 1 deletion code/core/src/preview-api/modules/store/args.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ describe('mapArgsToTypes', () => {
expect(mapArgsToTypes({ a: 1.2 }, { a: { type: boolObjectType } })).toStrictEqual({ a: 1.2 });
});

it('passes primitives for ReactNode type', () => {
it('passes only primitives for ReactNode type', () => {
expect(mapArgsToTypes({ a: 'foo bar' }, { a: { type: reactNodeType } })).toStrictEqual({
a: 'foo bar',
});
Expand Down