Skip to content

Addon Vitest: Reset currentRun data when starting new test #31950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghengeveld wants to merge 4 commits into from
Closed

Addon Vitest: Reset currentRun data when starting new test #31950

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6546706
Reset currentRun to initial state when starting new test run
ghengeveld Jul 3, 2025
02174c2
Check for Starting text as well
ghengeveld Jul 3, 2025
3943452
Avoid noisy logs, they aren't helpful
ghengeveld Jul 3, 2025
ecc53a4
Reevaluate locator for each assertion
ghengeveld Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions code/addons/vitest/src/preset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ export const experimental_serverChannel = async (channel: Channel, options: Opti
testProviderStore.setState('test-provider-state:running');
store.setState((s) => ({
...s,
currentRun: storeOptions.initialState.currentRun,
fatalError: undefined,
}));
runTestRunner({
Expand Down
4 changes: 2 additions & 2 deletions test-storybooks/portable-stories-kitchen-sink/react/e2e-tests/component-testing.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,8 @@ test.describe("component testing", () => {

await runTestsButton.click();
await expect(watchModeButton).toBeDisabled();

await expect(testingModuleDescription).toContainText("Testing");
await expect(testingModuleDescription).toContainText("Starting...");
await expect(testingModuleDescription).toContainText("Testing...");

// Wait for test results to appear
await expect(testingModuleDescription).toHaveText(/Ran \d+ tests/, {
Expand Down
2 changes: 0 additions & 2 deletions test-storybooks/portable-stories-kitchen-sink/react/playwright-e2e.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,5 @@ export default defineConfig({
command: "yarn storybook",
url: "http://127.0.0.1:6006",
reuseExistingServer: true,
stdout: "pipe",
stderr: "pipe",
},
});