CI: Skip check for Starting text to prevent E2E flake

[ghengeveld]

What I did

Another attempt at getting E2E tests to stabilize. Checking for the "Starting" text is functionally appropriate but very easy for Playwright to miss because it may appear only very briefly. It's not really worth checking for so it's better to skip it. The default timeout of 5 seconds should be enough for Vitest to start (if it hasn't already, most likely) so the 10 second override isn't necessary.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Improves E2E test stability by removing flaky UI state check in component testing suite.

• Removed check for transient 'Starting' text state in test-storybooks/portable-stories-kitchen-sink/react/e2e-tests/component-testing.spec.ts
• Eliminated unnecessary 10-second timeout override, relying on default 5-second timeout
• Maintains effective test coverage while reducing false failures from timing-sensitive assertions
• Focuses on core functionality verification rather than intermediate UI states

[greptile-apps]

_{1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit e9baf12

Command	Status	Duration	Result
nx run-many -t build --parallel=3	✅ Succeeded	1m 14s	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-07-07 10:50:28 UTC

[storybook-app-bot]

Package Benchmarks

^{Commit: e9baf12, ran on 7 July 2025 at 10:37:56 UTC}

The following packages have significant changes to their size or dependencies:

storybook

	Before	After	Difference
Dependency count	51	51	0
Self size	31.73 MB	31.75 MB	🚨 +15 KB 🚨
Dependency size	17.43 MB	17.43 MB	0 B
Bundle Size Analyzer	Link	Link

sb

	Before	After	Difference
Dependency count	52	52	0
Self size	1 KB	1 KB	0 B
Dependency size	49.16 MB	49.18 MB	🚨 +15 KB 🚨
Bundle Size Analyzer	Link	Link

@storybook/cli

	Before	After	Difference
Dependency count	217	217	0
Self size	582 KB	582 KB	0 B
Dependency size	94.80 MB	94.81 MB	🚨 +15 KB 🚨
Bundle Size Analyzer	Link	Link

@storybook/codemod

	Before	After	Difference
Dependency count	186	186	0
Self size	31 KB	31 KB	0 B
Dependency size	78.90 MB	78.91 MB	🚨 +15 KB 🚨
Bundle Size Analyzer	Link	Link