Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Aug 27, 2025

  • Create comprehensive GitHub Copilot documentation with build commands and timing data
  • Document proper sandbox workflow using yarn task --task sandbox --template [framework]
  • Clarify repository structure with accurate directory descriptions
  • Test and verify sandbox generation works (GitHub API rate limit resolved)
  • Add type checking section using yarn task --task check
  • Add compilation requirements for Storybook UI commands
  • Update development workflow to compile before testing
  • Include renderers in addon/framework development section
  • Update all GitHub API rate limit references - issue resolved
  • Re-apply all missing changes that were not included in the previous commit
  • Address all reviewer feedback and suggestions

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@JReinhold JReinhold marked this pull request as ready for review August 28, 2025 07:23
@nx-cloud
Copy link

nx-cloud bot commented Aug 28, 2025

View your CI Pipeline Execution ↗ for commit 0f78a19

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 42s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-25 08:25:00 UTC

@nx-cloud
Copy link

nx-cloud bot commented Aug 28, 2025

View your CI Pipeline Execution ↗ for commit cf66c16

Command Status Duration Result
nx run-many -t build -c production --parallel=3 ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-28 07:24:47 UTC

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2025

Fails
🚫 PR title must be in the format of "Area: Summary", With both Area and Summary starting with a capital letter Good examples: - "Docs: Describe Canvas Doc Block" - "Svelte: Support Svelte v4" Bad examples: - "add new api docs" - "fix: Svelte 4 support" - "Vue: improve docs"

Generated by 🚫 dangerJS against 0f78a19

@JReinhold JReinhold added the build Internal-facing build tooling & test updates label Aug 28, 2025
@JReinhold
Copy link
Contributor

@copilot great investigations, but you tried to run yarn task --task dev, which is a permanent dev server that doesn't stop. So you timed out while waiting for that process to end. Maybe try again, but without running dev.

@JReinhold JReinhold added ci:docs Run the CI jobs for documentation checks only. and removed ci:normal labels Aug 28, 2025
Copy link
Contributor Author

Copilot AI commented Aug 28, 2025

@copilot great investigations, but you tried to run yarn task --task dev, which is a permanent dev server that doesn't stop. So you timed out while waiting for that process to end. Maybe try again, ...

Thanks for the feedback! You're absolutely right - yarn task --task dev starts a permanent development server. I'll continue with the investigation and focus on completing the copilot instructions without running the dev server that would timeout.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • cloud.nx.app
    • Triggering command: /usr/local/bin/node ./bin/post-install (dns block)
    • Triggering command: /usr/local/bin/node /home/REDACTED/work/storybook/storybook/code/node_modules/.bin/nx run-many -t build --parallel=3 (dns block)
  • https://api.github.com/repos/storybookjs/sandboxes/tarball/next
    • Triggering command: /usr/local/bin/node /home/REDACTED/work/storybook/storybook/code/lib/cli-storybook/dist/bin/index.js repro react-vite/default-ts --output /home/REDACTED/work/storybook/storybook/sandbox/react-vite-default-ts --no-init --debug (http block)
  • main--64b56e737c0aeefed9d5e675.chromatic.com
    • Triggering command: /usr/local/bin/node core/dist/bin/dispatcher.js dev --port 6006 --config-dir ./.storybook (dns block)
  • storybook.js.org
    • Triggering command: /usr/local/bin/node core/dist/bin/dispatcher.js dev --port 6006 --config-dir ./.storybook (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] ✨ Set up Copilot instructions ✨ Add comprehensive GitHub Copilot instructions for Storybook development Aug 28, 2025
Copilot AI requested a review from JReinhold August 28, 2025 07:39
6. Run relevant tests: `cd code && yarn test`

### For Testing UI Changes
1. Use existing sandbox environments in `code/sandbox/`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot this is wrong, you can't use code/sandbox for anything. you have to first generate a sandbox with the framework/builder+renderer combination that you need to test out your stuff using yarn task --task sandbox and selecting the appropriate sandbox. Eg. if you're making changes to Svelte code, you probably want to select the svelte-vite/defaults-ts sandbox. Then you can cd sandbox/svelte-vite-default-ts and start Storybook from there or whatever.

Probably try this out to see how it works before you document it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right - I've completely rewritten the sandbox section. Now correctly documents using yarn task --task sandbox --template [framework] to generate sandboxes in the root sandbox/ directory, not code/sandbox/. Also noted that sandbox creation currently fails in CI due to GitHub API limits (403 Forbidden), with proper fallback workflow using Storybook UI. Commit: 8d14963

Copy link
Contributor Author

Copilot AI commented Aug 28, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • cloud.nx.app
    • Triggering command: /usr/local/bin/node /home/REDACTED/work/storybook/storybook/code/node_modules/.bin/nx run-many -t build --parallel=3 (dns block)
  • https://api.github.com/repos/storybookjs/sandboxes/tarball/next
    • Triggering command: /usr/local/bin/node /home/REDACTED/work/storybook/storybook/code/lib/cli-storybook/dist/bin/index.js repro react-vite/default-ts --output /home/REDACTED/work/storybook/storybook/sandbox/react-vite-default-ts --no-init --debug (http block)
  • main--64b56e737c0aeefed9d5e675.chromatic.com
  • storybook.js.org
    • Triggering command: /usr/local/bin/node core/dist/bin/dispatcher.js build --config-dir ./.storybook --webpack-stats-json (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title ✨ Add comprehensive GitHub Copilot instructions for Storybook development ✨ Add comprehensive GitHub Copilot instructions with corrected sandbox workflow and build commands Aug 28, 2025
Copilot AI requested a review from JReinhold August 28, 2025 14:55
@github-actions github-actions bot added the Stale label Sep 11, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 25, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch copilot/fix-32338

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor Author

Copilot AI commented Sep 25, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://storage.googleapis.com/prod-north-america/606dc2e0c2e8d5671d813305/1630eac8-6565-4fa7-8afc-5d7e309824fb-logs
    • Triggering command: /usr/local/bin/node /home/REDACTED/work/storybook/storybook/code/node_modules/.bin/nx run-many -t build --parallel=3 (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title ✨ Add comprehensive GitHub Copilot instructions with corrected sandbox workflow and build commands ✨ Add comprehensive GitHub Copilot instructions with verified sandbox workflow and enhanced build commands Sep 25, 2025
Copilot AI requested a review from JReinhold September 25, 2025 08:03
@JReinhold
Copy link
Contributor

@copilot your last work responding to my comments didn't get into the branch, maybe because I committed while you were working, please re-try.

…x API rate limit documentation

Co-authored-by: JReinhold <[email protected]>
Copy link
Contributor Author

Copilot AI commented Sep 25, 2025

@copilot your last work responding to my comments didn't get into the branch, maybe because I committed while you were working, please re-try.

Re-applied all the missing changes that didn't make it into the previous commit. Added the Type Checking section using yarn task --task check and updated all GitHub API rate limit references throughout the document - confirmed that sandbox creation now works (the API rate limiting issue has been resolved). Commit: 0f78a19

@JReinhold JReinhold changed the title ✨ Add comprehensive GitHub Copilot instructions with verified sandbox workflow and enhanced build commands Docs: ✨ Add comprehensive GitHub Copilot instructions with verified sandbox workflow and enhanced build commands Sep 25, 2025
@JReinhold JReinhold merged commit 0bcdc29 into next Sep 25, 2025
1 check passed
@JReinhold JReinhold deleted the copilot/fix-32338 branch September 25, 2025 09:20
@github-actions github-actions bot mentioned this pull request Sep 25, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants