-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Docs: Add CSF Next snippets #32357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add CSF Next snippets #32357
Conversation
|
View your CI Pipeline Execution ↗ for commit 9663fad
☁️ Nx Cloud last updated this comment at |
336bfb9 to
1e2b464
Compare
1e2b464 to
50269a7
Compare
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 88 files out of 300 files are above the max files limit of 200. You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
- `docs:codemod csf-factory-story --glob="*.md"`
- `docs:codemod csf-factory-config --glob="*.md"`
- Codemod unable to run on incomplete stories files ("...rest of story file")
- Some uncaught usages of Stories.Story.args -> Stories.Story.input.args
50269a7 to
bfc216b
Compare
|
|
* next: (277 commits) Bump version from "10.0.0-beta.6" to "10.0.0-beta.7" [skip ci] Write changelog for 10.0.0-beta.7 [skip ci] Update yarn utility to handle errors when removing .yarnrc.yml file during installation Update yarn utility to remove existing .yarnrc.yml file during installation fix failing react sandboxes optimizeDeps app state mock to ensure vitest doesn't reload clear yarn.lock content update updated docs make url mock static in stories provide features via the vitest integration cleanup enable async stories Update Tool component to allow isRotated to be undefined, enhancing type flexibility update svelte related packages enable test syntax in storybook:ui fix lint Fix types Update Tool component type definitions for viewportName and isRotated to improve type safety Refactor viewport handling in Vitest plugin and Tool component to use consistent type definitions for options and viewports cleanup ...
* next: Re-apply missing changes: add type checking section and update sandbox API rate limit documentation Apply suggestions from code review Apply suggestions from code review Fix missing props Improve sidebar empty state remove re-throwing error cleanup debugging Remove unused Angular preset file to streamline framework imports debug more let's debug this Refactor preset imports in Angular framework to use fileURLToPath for better compatibility fix: pass an index in handleAddValueAdd Do not use path.join to create package.json module paths Update yarn pnp to correctly resolve addons Use exsolve's resolveModulePath for safeResolveModule Update copilot instructions based on feedback: add build command, fix sandbox documentation Create comprehensive GitHub Copilot instructions documentation Initial plan
jonniebigodes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this pull request together and getting the snippets updated to include the CSF Next format. I've checked through the snippets and found several issues that need to be addressed before we can merge this in. Also, while we're at it, I'm going to check the rest of them as well to make sure everything is in order, see if we didn't miss anything, and have a full audit of the snippets to make sure everything is in order.
docs/_snippets/storybook-preview-auto-docs-custom-docs-container.md
Outdated
Show resolved
Hide resolved
docs/_snippets/storybook-preview-auto-docs-custom-template-function.md
Outdated
Show resolved
Hide resolved
|
I've checked and the following snippets were not converted:
|
* next: (101 commits) Update assertion now that unhandled errors are shown correctly Fix interactions bar alignment Update E2E tests Prevent play status from leaving terminal state Expand selected story with tests on initialization Show tooltip on story status badge Avoid modern Set operators improve story index structure and types use full commit SHA for third party action Update docs/api/main-config/main-config-indexers.mdx simplify branching logic bail from workflow early if conditions aren't met Update action references and improve environment variable handling in workflows based on https://docs.github.com/en/actions/reference/security/secure-use simplify deps installation update docs cleanup Refactor Node.js setup and dependency installation across workflows extract node and dependency setup into reusable action merge canary workflow into publish workflow Telemetry: Add metadata for react routers ...
Co-authored-by: jonniebigodes <[email protected]>
* next: Update filter image Update docs/writing-stories/tags.mdx Update docs/api/main-config/main-config-tags.mdx Docs: Update tags, add filtering Fix: Incorrect URLS for the upgrade command
* next: Updates from review Docs: Add experimental test syntax to main config features page Prevent onboarding confetti overlay from intercepting pointer events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took another pass at this and left some items for you to look into, when you're able. Nothing major.
Also, it seems that one of the snippets, specifically the main-config-builder-custom-config.md that's used in the Vite builder documentation was not properly converted.
Approving to unblock you
| import MockDate from 'mockdate'; | ||
|
|
||
| import preview from '../.storybook/preview'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you're able, can you adjust the import order in the CSF Next to align with the other examples as follows:
| import MockDate from 'mockdate'; | |
| import preview from '../.storybook/preview'; | |
| import preview from '../.storybook/preview'; | |
| import MockDate from 'mockdate'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint's default configuration will place absolute imports above relative ones. So while it made sense to place the SB imports first prior to CSF Next, the relative import of the preview file should now be after any absolute imports.
Co-authored-by: jonniebigodes <[email protected]>
* next: Update PR template to correct canary release workflow link Bump version from "10.0.0-beta.9" to "10.0.0-beta.10" [skip ci] fix story test Customize text for production mode fix story change qrcode text in prod Write changelog for 10.0.0-beta.10 [skip ci] Ensure valid QR code URL
What I did
Checklist for Contributors
Testing
Manual testing
docs-csf-next-snippetsweb, check outremember-tab-choicebranch (see Store docs snippet tab selection in cookie web#325)Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.