Skip to content

Manager: Upgrade to react v19 for manager UI & Addons (SPIKE) #32406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ndelangen wants to merge 35 commits into
base: next
Choose a base branch
from
Draft

Manager: Upgrade to react v19 for manager UI & Addons (SPIKE) #32406

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
cde5482
Reapply "upgrade to react 19"
ndelangen Sep 4, 2025
f59c39c
Upgrade react-inspector from version 8.0.0 to 9.0.0 in package.json a…
ndelangen Sep 4, 2025
757824e
Refactor sanitizeName function to explicitly type key as string
ndelangen Sep 4, 2025
6d6597d
Upgrade @types/react and @types/react-dom to version 19.1.12 and 19.1…
ndelangen Sep 4, 2025
8aa0d9e
Upgrade @types/react from version 18.0.0 to 19.0.0 in package.json
ndelangen Sep 4, 2025
80ccafd
Refactor TagsFilterPanel component to use useMemo for performance opt…
ndelangen Sep 4, 2025
2dd713b
Update TypeScript configuration and improve type safety in components
ndelangen Sep 4, 2025
95299aa
Refactor TypeScript configuration and enhance component type safety
ndelangen Sep 5, 2025
12b8f81
Merge branch 'next' into norbert/upgrade-react
ndelangen Sep 10, 2025
6e171ec
Enhance TypeScript type safety across multiple components
ndelangen Sep 10, 2025
cd348a9
Update TypeScript configuration to change module and target settings
ndelangen Sep 10, 2025
7ec96aa
Merge branch 'next' into norbert/upgrade-react
ndelangen Sep 18, 2025
87bc2ae
Update gitHead in multiple package.json files to a new commit hash a8…
ndelangen Sep 18, 2025
e7fdcbb
Add estree-walker dependency to package.json and yarn.lock
ndelangen Sep 18, 2025
5fc6a92
regen lockfile
ndelangen Sep 18, 2025
3844821
Update react-resize-detector dependency to version 12.3.0 in package.…
ndelangen Sep 18, 2025
d2c4a66
Update dependencies in package.json and yarn.lock for @radix-ui and @…
ndelangen Sep 18, 2025
bb2261f
Enhance ESLint rule documentation and test generation script by addin…
ndelangen Sep 18, 2025
f11d006
Refactor TestingModule to optimize height calculation with requestAni…
ndelangen Sep 18, 2025
5405f71
Update snapshot files to replace ts-ignore with ts-expect-error for d…
ndelangen Sep 18, 2025
11647e6
Fix typo in StoryContent component by correcting 'popovertarget' to '…
ndelangen Sep 18, 2025
75ab041
Refactor useTestProvider to ensure consistent timeout handling for se…
ndelangen Sep 19, 2025
5023b5b
Refactor FileSearchList component to use useRef with null type for pa…
ndelangen Sep 23, 2025
125c779
Merge branch 'next' into norbert/upgrade-react
ndelangen Sep 23, 2025
8e0f893
Update error message in handleProp.test.tsx to reflect changes in Rea…
ndelangen Sep 23, 2025
d1f8b43
Merge branch 'next' into norbert/upgrade-react
ndelangen Sep 23, 2025
9900a33
Merge branch 'next' into norbert/upgrade-react
ndelangen Sep 26, 2025
d80572d
Merge branch 'next' into norbert/upgrade-react
ndelangen Sep 29, 2025
8218553
regen lockfile
ndelangen Sep 29, 2025
9fe2f8f
refactor: update component definition to use defineComponent for impr…
ndelangen Sep 29, 2025
afb42a9
Merge branch 'next' into norbert/upgrade-react
ndelangen Sep 29, 2025
6c2c218
fix: update ActionLogger to use ComponentRef for improved type safety
ndelangen Sep 29, 2025
be84275
fix: clarify TypeScript error comment in tabs.hooks.tsx
ndelangen Sep 29, 2025
d7d14c4
fix: improve type safety by importing RefObject in ZoomElement component
ndelangen Sep 29, 2025
6fb36b1
fix: simplify expanded state initialization in useExpanded for better…
ndelangen Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions code/addons/a11y/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@
"@storybook/icons": "^1.4.0",
"@testing-library/react": "^14.0.0",
"execa": "^9.5.2",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-resize-detector": "^7.1.2",
"react": "^19.1.1",
"react-dom": "^19.1.1",
"react-resize-detector": "^12.3.0",
"typescript": "^5.8.3",
Comment on lines +70 to 73
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

🧩 Analysis chain

React 19 devDeps: verify ecosystem compatibility (esp. Testing Library).

Looks fine, but please confirm:

  • @testing-library/react version used here (still ^14.0.0 in repo elsewhere) doesn’t warn on React 19 peers.
  • react-resize-detector ^12.3.0 explicitly supports React 19.

🌐 Web query:

Does @testing-library/react v14 support React 19 (peerDependencies and compatibility)?

💡 Result:

Short answer: No — v14 does not officially support React 19. v14's peerDependencies target React 18 (so installing with React 19 will produce a peer-dep conflict). [1][2]

Recommendation: upgrade @testing-library/react to a version that adds React 19 support (projects migrating to React 19 report using later RTL releases, e.g. v16.x in practice). [3]

Sources:

  • Issue showing v14 peerDependencies require React 18. [1]
  • @testing-library/react package docs noting v13+ require React 18. [2]
  • Example migration noting use of @testing-library/react v16.x with React 19. [3]

🌐 Web query:

Is react-resize-detector v12 compatible with React 19?

💡 Result:

Yes — react-resize-detector v12 declares React ^18.0.0 || ^19.0.0 as a peer dependency (e.g. v12.0.2 package.json). [1]

Sources

  • package.json for [email protected] (peerDependencies: "react": "^18.0.0 || ^19.0.0"). [1]

Action: bump @testing-library/react to a React‑19‑compatible release; react-resize-detector v12 is OK.

  • @testing-library/react v14 targets React 18 (peerDeps) and will produce a peer-dep conflict with React 19 — upgrade to a v16.x (or later) release that declares React 19 support and update the lockfile/CI.
  • react-resize-detector v12 declares "react": "^18.0.0 || ^19.0.0" — no change required.
  • Location(s): repo uses React ^19.1.1 in code/addons/a11y/package.json; search the repo for any package.json entries with @testing-library/react ^14.0.0 and bump them.
🤖 Prompt for AI Agents 
In code/addons/a11y/package.json around lines 70-73 the project depends on React
^19.1.1 but @testing-library/react v14 targets React 18 and will cause a
peer-dep conflict; bump any @testing-library/react entries (starting in this
file and across the repo) to a React‑19‑compatible release (e.g., ^16.x or later
that declares React 19 support), leave react-resize-detector v12 as-is, update
the lockfile (npm/yarn/pnpm) and CI artifacts, and run install/tests to verify
no remaining peer-dep warnings.

"vitest-axe": "^0.1.0"
},
Expand Down
4 changes: 2 additions & 2 deletions code/addons/docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@
"markdown-to-jsx": "^7.7.2",
"memoizerific": "^1.11.3",
"polished": "^4.2.2",
"react": "^18.2.0",
"react": "^19.1.1",
"react-colorful": "^5.1.2",
"react-dom": "^18.2.0",
"react-dom": "^19.1.1",
"rehype-external-links": "^3.0.0",
"rehype-slug": "^6.0.0",
"telejson": "8.0.0",
Expand Down
4 changes: 2 additions & 2 deletions code/addons/jest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@
},
"devDependencies": {
"@storybook/icons": "^1.4.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.1.1",
"react-dom": "^19.1.1",
"react-resize-detector": "^7.1.2",
"typescript": "^5.8.3"
},
Expand Down
4 changes: 2 additions & 2 deletions code/addons/onboarding/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@
"devDependencies": {
"@neoconfetti/react": "^1.0.0",
"@storybook/icons": "^1.4.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.1.1",
"react-dom": "^19.1.1",
Comment on lines +56 to +57
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

🧩 Analysis chain

React 19 bump LGTM; please verify deduped versions across the workspace.

Ensure all packages resolve to a single React/React DOM (19.x) to avoid multiple React copies at runtime.

Run:

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "All declared react/react-dom versions:"
rg -nP --glob 'package.json' '"react(?:-dom)?":\s*"[^"]+"'

echo
echo "Any non-19 or non-workspace declarations (should be empty):"
rg -nP --glob 'package.json' '"react(?:-dom)?":\s*"(?!\^?19|workspace:)[^"]+"' || true

Length of output: 4380

React 19 bump — fix remaining non-19 package.json entries

These files still declare React/React‑DOM outside 19.x; update them to ^19.1.1 (or use workspace:) so the workspace resolves a single React/React‑DOM:

  • test-storybooks/standalone-preview/package.json: "react": "16.14.0", "react-dom": "^18.2.0"
  • test-storybooks/external-docs/package.json: "react": "16.14.0", "react-dom": "^18.2.0"
  • test-storybooks/portable-stories-kitchen-sink/react/package.json: "react": "^18.0.0", "react-dom": "^18.0.0"
  • test-storybooks/portable-stories-kitchen-sink/nextjs/package.json: "react": "^18.2.0", "react-dom": "^18.2.0"
  • scripts/package.json: "react": "^18.3.1", "react-dom": "^18.3.1"
  • test-storybooks/yarn-pnp/package.json: "react": "^19.1.0", "react-dom": "^19.1.0" (consider matching ^19.1.1)
🤖 Prompt for AI Agents 
In code/addons/onboarding/package.json around lines 56-57 and in the other
project package.json files listed
(test-storybooks/standalone-preview/package.json,
test-storybooks/external-docs/package.json,
test-storybooks/portable-stories-kitchen-sink/react/package.json,
test-storybooks/portable-stories-kitchen-sink/nextjs/package.json,
scripts/package.json, test-storybooks/yarn-pnp/package.json), update the react
and react-dom entries to match ^19.1.1 (or replace with "workspace:*"/workspace:
convention used by the monorepo) so the workspace resolves a single
React/React-DOM; change any exact older versions (e.g., 16.14.0, ^18.x) to
^19.1.1 (or workspace:), run npm/yarn install to refresh lockfiles, and verify
Storybook/test projects build with the unified React version.

"react-joyride": "^2.8.2",
"typescript": "^5.8.3"
},
Expand Down
4 changes: 2 additions & 2 deletions code/addons/pseudo-states/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@
},
"devDependencies": {
"@storybook/icons": "^1.4.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.1.1",
"react-dom": "^19.1.1",
"typescript": "^5.8.3"
},
"peerDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions code/addons/themes/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@
},
"devDependencies": {
"@storybook/icons": "^1.4.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.1.1",
"react-dom": "^19.1.1",
"typescript": "^5.8.3"
},
"peerDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions code/addons/vitest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@
"micromatch": "^4.0.8",
"pathe": "^1.1.2",
"picocolors": "^1.1.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.1.1",
"react-dom": "^19.1.1",
"semver": "^7.6.3",
"sirv": "^2.0.4",
"slash": "^5.0.0",
Expand Down
14 changes: 7 additions & 7 deletions code/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@
"@types/pretty-hrtime": "^1.0.0",
"@types/prompts": "^2.0.9",
"@types/react-syntax-highlighter": "11.0.5",
"@types/react-transition-group": "^4",
"@types/react-transition-group": "^4.4.12",
"@types/semver": "^7.5.8",
"@types/ws": "^8",
"@vitest/utils": "^3.2.4",
Expand Down Expand Up @@ -338,14 +338,14 @@
"prettier": "^3.5.3",
"pretty-hrtime": "^1.0.3",
"prompts": "^2.4.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-helmet-async": "^1.3.0",
"react-inspector": "^6.0.0",
"react": "^19.1.1",
"react-dom": "^19.1.1",
"react-helmet-async": "^2.0.5",
"react-inspector": "^8.0.0",
"react-popper-tooltip": "^4.4.2",
"react-router-dom": "6.15.0",
"react-syntax-highlighter": "^15.4.5",
"react-textarea-autosize": "^8.3.0",
"react-syntax-highlighter": "^15.6.6",
"react-textarea-autosize": "^8.5.9",
"react-transition-group": "^4.4.5",
"require-from-string": "^2.0.2",
"resolve-from": "^5.0.0",
Expand Down
2 changes: 1 addition & 1 deletion code/lib/create-storybook/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"ora": "^5.4.1",
"picocolors": "^1.1.0",
"prompts": "^2.4.0",
"react": "^18.2.0",
"react": "^19.1.1",
"tiny-invariant": "^1.3.1",
"ts-dedent": "^2.0.0",
"typescript": "^5.8.3"
Expand Down
6 changes: 3 additions & 3 deletions code/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
"esbuild": "^0.25.3",
"playwright": "1.52.0",
"playwright-core": "1.52.0",
"react": "^18.2.0",
"react": "^19.1.1",
"serialize-javascript": "^3.1.0",
"type-fest": "~2.19",
"typescript": "^5.8.3"
Expand Down Expand Up @@ -198,8 +198,8 @@
"prettier-plugin-jsdoc": "^1.3.0",
"prettier-plugin-merge": "^0.7.0",
"process": "^0.11.10",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react": "^19.1.1",
"react-dom": "^19.1.1",
"rimraf": "^6.0.1",
"slash": "^5.0.0",
"sort-package-json": "^2.14.0",
Expand Down
Loading
Loading