-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Core: Add "open in editor" feature #32452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
1853097
Integrate launch-editor-middleware for enhanced editor support. Added…
yannbf b665876
Introduce open in editor and copy story name actions in sidebar conte…
yannbf 534e35b
add open in editor action in interactions panel
yannbf e5bcac0
Add share tool functionality with QR code support in the preview comp…
yannbf 90b7020
surface network address to Storybook's UI
yannbf c110aed
fix types and most tests
yannbf 4c3209a
fix story
yannbf c83b79c
only hide tooltip on escape key
yannbf f16eb5d
update storybook icons and use new bug icon
yannbf f72aa77
fix exports
yannbf 33f12f1
use share icon
yannbf 983e479
in the interactions panel, show just story name as text on deployed/c…
yannbf 7a74161
fix shortcuts fonts
yannbf 22e796c
fix registering shortcuts with alt on macos
yannbf cceb627
fix tests
yannbf 4ce4bfd
cleanup and add copyStoryLink shortcut
yannbf 03ddcf9
temporarily disable copy story name shortcut
yannbf 1af1dbb
small rename on measure addon shortcut
yannbf 0036635
fix qr url
yannbf f252cdb
small refactor
yannbf 383fe6f
fix types
yannbf f4bb5fa
fix types
yannbf 09cdcc3
Merge branch 'next' into yann/open-in-editor-feature
yannbf 6636c1d
make qrcode fallback to current url
yannbf 809d220
add copy story link default shortcut
yannbf 45daed4
skip vitest test
yannbf 632561d
fix qr code url calculation
yannbf 72d98b7
Merge branch 'next' into yann/open-in-editor-feature
yannbf 5be73b1
update icons and use the new editor icon
yannbf c8e2ac3
Merge branch 'next' into yann/open-in-editor-feature
ndelangen 6984ccd
Enhance exports: Add 'EditorIcon' to the list of exported icons in gl…
ndelangen e442493
Merge branch 'yann/open-in-editor-feature' of github.com:storybookjs/…
yannbf 90817f1
rework the open in editor feature and add error handling
yannbf cf13e70
address PR feedback
yannbf 244fac1
revamp context menu and support opening mdx stories
yannbf 7fad5ab
Merge branch 'next' into yann/open-in-editor-feature
ndelangen cd1b6e5
replace qrcode library
yannbf 43d966b
Merge branch 'yann/open-in-editor-feature' of github.com:storybookjs/…
yannbf a363ba8
more fixes
yannbf aeb30b3
Merge branch 'next' into yann/open-in-editor-feature
yannbf d0653ad
fix stories
yannbf 8c61a23
Merge branch 'next' into yann/open-in-editor-feature
ndelangen 1190cb5
fix: add missing newline in no-stories-of.md documentation
ndelangen efd5294
fix: update comments and formatting in test and CSS files
ndelangen 7ebc251
Merge branch 'next' into yann/open-in-editor-feature
ndelangen e194a32
prebundle qrcode.react
yannbf c58e9e9
add "open in editor" action to component nodes
yannbf a744783
address PR feedback
yannbf bbfa9e9
write E2E tests
yannbf a6b51dc
revamp open in editor api and bring it into useStorybookApi
yannbf 6c985c5
Merge branch 'next' into yann/open-in-editor-feature
yannbf 21529d2
fix test
yannbf 3b49d88
Merge branch 'yann/open-in-editor-feature' of github.com:storybookjs/…
yannbf af37fd7
fix tests
yannbf 269c931
better structure E2E tests
yannbf cc2ffba
Merge branch 'next' into yann/open-in-editor-feature
yannbf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| export type OpenInEditorRequestPayload = { file: string; line?: number; column?: number }; | ||
|
|
||
| export type OpenInEditorResponsePayload = { | ||
| file: string; | ||
| line?: number; | ||
| column?: number; | ||
| error: string | null; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.