extend documentation on how to use knob in Angular #3247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-dv
reviewed
Mar 21, 2018
addons/knobs/README.md
Outdated
|
|
||
| const stories = storiesOf('Storybook Knobs', module); | ||
|
|
||
| // The "addDecorator" must come before the "add" |
Member
There was a problem hiding this comment.
I would say
"withKnobs" decorator should be applied before the stories using knobs
addons/knobs/README.md
Outdated
| stories.add('with text', () => ({ | ||
| component: Button, | ||
| props: { | ||
| text: text('text', 'Hello Button'), // The first param on the text knob has to be exactly the same as the component input. |
Member
There was a problem hiding this comment.
The first param of the knob function.
Hypnosphi
added
the
patch:yes
Hypnosphi
added
the
patch:done
Hypnosphi
added a commit
that referenced
this pull request
Mar 29, 2018
extend documentation on how to use knob in Angular
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
I extended documentation on how to use knob inputs in Angular
How to test
Is this testable with jest or storyshots?
No
Does this need a new example in the kitchen sink apps?
Maybe we could add one?
Does this need an update to the documentation?
N/A
If your answer is yes to any of these, please make sure to include it in your PR.