Skip to content

Conversation

@ndelangen
Copy link
Member

@ndelangen ndelangen commented Sep 17, 2025

What I did

I removed the globalization of exports we wanted to drop, and shouldn't be used anymore.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Refactor
    • Removed deprecated internal globals for core errors, manager API, and theming, reducing the publicly exposed surface.
  • Chores
    • Cleaned up global mappings to align with current supported internals.
  • Developer Notice
    • Addon authors or custom integrations relying on previously exposed internals may break. Migrate to supported public APIs to restore compatibility.
    • No end-user UI changes or behavior adjustments are expected.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 17, 2025

Walkthrough

Removed four internal package mappings from globals export, reference, and runtime maps: storybook/internal/core-errors, storybook/internal/manager-api, storybook/internal/theming, and storybook/internal/theming/create. No other logic or control-flow changes.

Changes

Cohort / File(s) Summary
Globals export map cleanup
code/core/src/manager/globals/exports.ts
Deleted four entries from the default export map: storybook/internal/core-errors, storybook/internal/manager-api, storybook/internal/theming, storybook/internal/theming/create. Remaining entries unchanged.
Globals name-reference map cleanup
code/core/src/manager/globals/globals.ts
Removed corresponding keys from globalsNameReferenceMap for the same four internal packages. Other mappings unchanged.
Runtime globals map cleanup
code/core/src/manager/globals/runtime.ts
Removed the same four keys from globalsNameValueMap initialization. No signature or behavior changes otherwise.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I tidied the map with a hop and a sweep,
Four keys gone missing—now fewer to keep.
No twists in the burrow, no new rabbit holes,
Just lighter backpacks for our strolling roles.
Thump-thump—onward! 🐇✨

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch norbert/remove-deprecated-exports-globals

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 63bb329 and 65a4506.

📒 Files selected for processing (3)
  • code/core/src/manager/globals/exports.ts (0 hunks)
  • code/core/src/manager/globals/globals.ts (0 hunks)
  • code/core/src/manager/globals/runtime.ts (0 hunks)
💤 Files with no reviewable changes (3)
  • code/core/src/manager/globals/runtime.ts
  • code/core/src/manager/globals/exports.ts
  • code/core/src/manager/globals/globals.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Core Unit Tests, windows-latest

Comment @coderabbitai help to get the list of available commands and usage tips.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The title "Maintenance: Remove globalization for dropped entrypoints" accurately and concisely reflects the primary change in the diffs (removal of globalized exports and mappings in exports.ts, globals.ts, and runtime.ts). It is specific, clear, and readable for a teammate scanning PR history.

@nx-cloud
Copy link

nx-cloud bot commented Sep 17, 2025

View your CI Pipeline Execution ↗ for commit 65a4506

Command Status Duration Result
nx run-many -t build -c production --parallel=3 ✅ Succeeded 3m 50s View ↗
nx run-many -t check -c production --parallel=7 ✅ Succeeded 1m 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-17 12:38:50 UTC

@ndelangen ndelangen changed the title remove globalization we decided to remove Maintenance: Remove globalization for dropped entrypoints Sep 17, 2025
@ndelangen ndelangen requested a review from yannbf September 17, 2025 12:24
@ndelangen ndelangen self-assigned this Sep 17, 2025
@ndelangen ndelangen added maintenance User-facing maintenance tasks core ci:normal labels Sep 17, 2025
@ndelangen ndelangen merged commit 5528525 into next Sep 17, 2025
62 of 66 checks passed
@ndelangen ndelangen deleted the norbert/remove-deprecated-exports-globals branch September 17, 2025 14:05
@github-actions github-actions bot mentioned this pull request Sep 17, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:normal core maintenance User-facing maintenance tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants