-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Docs: Remove autodocs configuration reference from the documentation #32535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDocumentation updates remove the autodocs config examples, replace docs.autodocs with docs.defaultName, add docs.docsMode in snippets, and update API and guide pages accordingly. No runtime or control-flow changes; all edits are to Markdown snippets and docs content. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
docs/configure/index.mdx (1)
36-36: Update link target to the docs config API page for accuracy.Linking “docs” to the Autodocs concept page is a bit indirect. Point to the main-config docs API reference instead.
-| `docs` | Configures Storybook's [auto-generated documentation](../writing-docs/autodocs.mdx)<br /> `docs: { defaultName: 'Documentation' }` | +| `docs` | Configures Storybook's [docs configuration](../api/main-config/main-config-docs.mdx)<br /> `docs: { defaultName: 'Documentation' }` |docs/_snippets/main-config-typical.md (1)
10-11: Standardize example defaultName to match the documented default.Elsewhere (autodocs.mdx) the default is shown as 'Docs'. Recommend using the same value here for consistency.
- defaultName: 'Documentation', + defaultName: 'Docs',Apply to both JS and TS snippets.
Also applies to: 28-29
docs/_snippets/storybook-auto-docs-full-config.md (1)
10-11: Align defaultName with the rest of the docs.Keep docsMode: true. Change defaultName to 'Docs' to match other references.
- defaultName: 'Documentation', + defaultName: 'Docs',Apply to both JS and TS snippets.
Also applies to: 26-27
docs/writing-docs/autodocs.mdx (1)
60-64: Standardize defaultName to 'Documentation' across docsdocs/writing-docs/autodocs.mdx:62 currently shows defaultName = 'Docs' — change it to 'Documentation' to match other occurrences (e.g. docs/configure/index.mdx:36, docs/_snippets/*).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
docs/_snippets/main-config-docs-autodocs.md(0 hunks)docs/_snippets/main-config-typical.md(2 hunks)docs/_snippets/storybook-auto-docs-full-config.md(2 hunks)docs/api/main-config/main-config-docs.mdx(0 hunks)docs/configure/index.mdx(1 hunks)docs/writing-docs/autodocs.mdx(1 hunks)
💤 Files with no reviewable changes (2)
- docs/_snippets/main-config-docs-autodocs.md
- docs/api/main-config/main-config-docs.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Danger JS
- GitHub Check: Core Unit Tests, windows-latest
|
View your CI Pipeline Execution ↗ for commit 5c42937
☁️ Nx Cloud last updated this comment at |
…cs_property Docs: Remove autodocs configuration reference from the documentation (cherry picked from commit 68fc759)
What I did
With this pull request, the documentation was updated to remove the non-existent autodocs property from the
docsconfiguration object, as it was removed in 9.0.What was done:
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Summary by CodeRabbit