-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
React Native: Fix document reference error in open-in-editor #32572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Native: Fix document reference error in open-in-editor #32572
Conversation
WalkthroughReplaced the static top-level import of Sequence Diagram(s)sequenceDiagram
autonumber
participant M as Manager Module (open-in-editor)
participant T as storybook/theming
participant U as Notification UI
Note over M: Dynamic import replaces previous static import
M->>M: init()
rect rgba(200, 220, 255, 0.25)
note right of M: New/changed interaction (async)
M->>T: import('storybook/theming')
activate T
T-->>M: { color }
deactivate T
end
M->>U: render notification using color.negative
opt Async timing
Note over M,U: Notification rendering awaits theming module
end
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Comment |
|
If someone could trigger a canary version then I could test to see if it works fully though I have already tested somewhat by editing in node_modules |
|
View your CI Pipeline Execution ↗ for commit 3c8cf0c
☁️ Nx Cloud last updated this comment at |
…orting manager-api
589deeb to
c957827
Compare
|
testing locally I found that changing the import to be relative fixes the bundling issue |
shilman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to understand the relative import better, but otherwise LGTM

Closes #
related to this:
storybookjs/react-native#795
What I did
Fixes an issue where react native storybook was crashing due to references to the document triggered by emotion web being loaded in storybook/theming
since this code isn't actually executed by RN then just moving it to be lazy loaded is enough to fix the crash.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-32572-sha-c9578275. Try it out in a new sandbox by runningnpx [email protected] sandboxor in an existing project withnpx [email protected] upgrade.More information
0.0.0-pr-32572-sha-c9578275dannyhw/feat/rn-fix-openeditor-document-reference-errorc95782751758911101)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=32572Summary by CodeRabbit