-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Telemetry: Add metadata for react routers #32615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe exported
No other files, logic, error handling, or control-flow were changed. Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (2)**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
**/*.{ts,tsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (1)
Comment |
|
View your CI Pipeline Execution ↗ for commit 68c0f14
☁️ Nx Cloud last updated this comment at |
| '@nrwl/storybook': 'nx', | ||
| '@vue/cli-service': 'vue-cli', | ||
| '@sveltejs/kit': 'sveltekit', | ||
| '@tanstack/react-router': 'tanstack-react', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other packages that might make sense to check
@tanstack/react-router-ssr-query, @tanstack/react-start
@remix-run/dev <-- it's the precursor to @react-router/dev
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 187 | 187 | 0 |
| Self size | 68 KB | 68 KB | 🎉 -36 B 🎉 |
| Dependency size | 31.77 MB | 31.78 MB | 🚨 +11 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 272 | 272 | 0 |
| Self size | 25 KB | 25 KB | 🎉 -36 B 🎉 |
| Dependency size | 43.43 MB | 43.44 MB | 🚨 +11 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/server-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 199 | 199 | 0 |
| Self size | 17 KB | 17 KB | 🎉 -18 B 🎉 |
| Dependency size | 33.02 MB | 33.03 MB | 🚨 +11 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
aabeab0 to
68c0f14
Compare
Telemetry: Add metadata for react routers (cherry picked from commit 391bbc6)
Telemetry: Add metadata for react routers (cherry picked from commit 391bbc6)
Closes N/A
What I did
Get numbers on tanstack / react-router
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Summary by CodeRabbit