Skip to content

Release tooling: Use npm Trusted Publishing for canaries #32621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JReinhold merged 9 commits into from
Oct 2, 2025
Merged

Release tooling: Use npm Trusted Publishing for canaries #32621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
52f5a31
merge canary workflow into publish workflow
JReinhold Oct 2, 2025
aa6b6c5
extract node and dependency setup into reusable action
JReinhold Oct 2, 2025
e9804b2
Refactor Node.js setup and dependency installation across workflows
JReinhold Oct 2, 2025
4a34bfd
cleanup
JReinhold Oct 2, 2025
a34329b
update docs
JReinhold Oct 2, 2025
1f910b7
simplify deps installation
JReinhold Oct 2, 2025
bd75379
Update action references and improve environment variable handling in…
JReinhold Oct 2, 2025
ea826af
bail from workflow early if conditions aren't met
JReinhold Oct 2, 2025
35ece30
simplify branching logic
JReinhold Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions .github/actions/setup-node-and-install/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
name: 'Setup Node.js and Install Dependencies'
description: 'Sets up Node.js, caches dependencies, and installs packages for Storybook'

inputs:
install-code-deps:
description: 'Whether to install code dependencies in addition to script dependencies'
required: false
default: 'false'

runs:
using: 'composite'
steps:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'

- name: Update npm to latest
shell: bash
run: npm install -g npm@latest

- name: Cache dependencies
uses: actions/cache@v4
with:
path: |
~/.yarn/berry/cache
key: yarn-v1-${{ hashFiles('scripts/yarn.lock') }}-${{ hashFiles('code/yarn.lock') }}
restore-keys: |
yarn-v1-${{ hashFiles('scripts/yarn.lock') }}-${{ hashFiles('code/yarn.lock') }}
yarn-v1-${{ hashFiles('scripts/yarn.lock') }}
yarn-v1

- name: Install script dependencies
shell: bash
working-directory: scripts
run: yarn install

- name: Install code dependencies
if: inputs.install-code-deps == 'true'
shell: bash
working-directory: code
run: yarn install
130 changes: 0 additions & 130 deletions .github/workflows/canary-release-pr.yml
View file
Open in desktop

This file was deleted.

14 changes: 7 additions & 7 deletions .github/workflows/generate-sandboxes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Generate and publish sandboxes

on:
schedule:
- cron: '2 2 */1 * *'
- cron: "2 2 */1 * *"
workflow_dispatch:
# To test fixes on push rather than wait for the scheduling, do the following:
# 1. Uncomment the lines below and add your branch.
Expand All @@ -14,8 +14,8 @@ on:
# 4. 👉 DON'T FORGET TO UNDO THE STEPS BEFORE YOU MERGE YOUR CHANGES!

env:
YARN_ENABLE_IMMUTABLE_INSTALLS: 'false'
CLEANUP_SANDBOX_NODE_MODULES: 'true'
YARN_ENABLE_IMMUTABLE_INSTALLS: "false"
CLEANUP_SANDBOX_NODE_MODULES: "true"

defaults:
run:
Expand All @@ -32,7 +32,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
node-version-file: ".nvmrc"

- name: Setup git user
run: |
Expand Down Expand Up @@ -68,7 +68,7 @@ jobs:
if: failure()
env:
DISCORD_WEBHOOK: ${{ secrets.DISCORD_MONITORING_URL }}
uses: Ilshidur/action-discord@master
uses: Ilshidur/action-discord@d2594079a10f1d6739ee50a2471f0ca57418b554
with:
args: |
The generation of some or all sandboxes on the **next** branch has failed.
Expand All @@ -84,7 +84,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
node-version-file: ".nvmrc"

- name: Setup git user
run: |
Expand Down Expand Up @@ -120,7 +120,7 @@ jobs:
if: failure()
env:
DISCORD_WEBHOOK: ${{ secrets.DISCORD_MONITORING_URL }}
uses: Ilshidur/action-discord@master
uses: Ilshidur/action-discord@d2594079a10f1d6739ee50a2471f0ca57418b554
with:
args: |
The generation of some or all sandboxes on the **main** branch has failed.
Expand Down
26 changes: 4 additions & 22 deletions .github/workflows/prepare-non-patch-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
prepare-non-patch-pull-request:
name: Prepare non-patch pull request
runs-on: ubuntu-latest
environment: release
environment: Release
defaults:
run:
working-directory: scripts
Expand All @@ -51,26 +51,8 @@ jobs:
fetch-depth: 10000
token: ${{ secrets.GH_TOKEN }}

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version-file: ".nvmrc"

- name: Cache dependencies
uses: actions/cache@v4
with:
path: |
~/.yarn/berry/cache
key: yarn-v1-${{ hashFiles('scripts/yarn.lock') }}-${{ hashFiles('code/yarn.lock') }}
restore-keys: |
yarn-v1-${{ hashFiles('scripts/yarn.lock') }}-${{ hashFiles('code/yarn.lock') }}
yarn-v1-${{ hashFiles('scripts/yarn.lock') }}
yarn-v1

- name: Install Dependencies
working-directory: .
run: |
yarn task --task=install
- name: Setup Node.js and Install Dependencies
uses: ./.github/actions/setup-node-and-install

- name: Check if pull request is frozen
if: github.event_name != 'workflow_dispatch'
Expand Down Expand Up @@ -160,6 +142,6 @@ jobs:
if: failure()
env:
DISCORD_WEBHOOK: ${{ secrets.DISCORD_MONITORING_URL }}
uses: Ilshidur/action-discord@master
uses: Ilshidur/action-discord@d2594079a10f1d6739ee50a2471f0ca57418b554
with:
args: "The GitHub Action for preparing the release pull request bumping from v${{ steps.bump-version.outputs.current-version }} to v${{ steps.bump-version.outputs.next-version }} (triggered by ${{ github.triggering_actor }}) failed! See run at: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
26 changes: 4 additions & 22 deletions .github/workflows/prepare-patch-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
prepare-patch-pull-request:
name: Prepare patch pull request
runs-on: ubuntu-latest
environment: release
environment: Release
defaults:
run:
working-directory: scripts
Expand All @@ -30,26 +30,8 @@ jobs:
ref: main
token: ${{ secrets.GH_TOKEN }}

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version-file: ".nvmrc"

- name: Cache dependencies
uses: actions/cache@v4
with:
path: |
~/.yarn/berry/cache
key: yarn-v1-${{ hashFiles('scripts/yarn.lock') }}-${{ hashFiles('code/yarn.lock') }}
restore-keys: |
yarn-v1-${{ hashFiles('scripts/yarn.lock') }}-${{ hashFiles('code/yarn.lock') }}
yarn-v1-${{ hashFiles('scripts/yarn.lock') }}
yarn-v1

- name: Install Dependencies
working-directory: .
run: |
yarn task --task=install
- name: Setup Node.js and Install Dependencies
uses: ./.github/actions/setup-node-and-install

- name: Check if pull request is frozen
if: github.event_name != 'workflow_dispatch'
Expand Down Expand Up @@ -183,6 +165,6 @@ jobs:
if: failure()
env:
DISCORD_WEBHOOK: ${{ secrets.DISCORD_MONITORING_URL }}
uses: Ilshidur/action-discord@master
uses: Ilshidur/action-discord@d2594079a10f1d6739ee50a2471f0ca57418b554
with:
args: "The GitHub Action for preparing the release pull request bumping from v${{ steps.versions.outputs.current }} to v${{ steps.versions.outputs.next }} (triggered by ${{ github.triggering_actor }}) failed! See run at: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
Loading
Loading