-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
CLI: Modernize Storybook CLI with new init workflow, Clack UI, and Generator System #32717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
352 commits
Select commit
Hold shift + click to select a range
c14bdd4
Update CircleCI configuration to use medium executor class for test-i…
valentinpalkovic 6f00339
Update CircleCI configuration to use medium+ executor class for test-…
valentinpalkovic f500eaf
Revert (for debugging purposes
valentinpalkovic a72ee5b
Refactor FrameworkDetectionCommand to enforce framework presence and …
valentinpalkovic 650fbfd
Refactor GeneratorExecutionCommand and baseGenerator to enhance frame…
valentinpalkovic 9bfb67b
Refactor baseGenerator to streamline framework package handling
valentinpalkovic a58ac65
Enhance Angular generator to prompt for Compodoc usage
valentinpalkovic 69a49be
Refactor generator execution and user preferences handling to improve…
valentinpalkovic fc738f3
Refactor GeneratorExecutionCommand to enhance type definitions and re…
valentinpalkovic 6ae03af
Fix tests
valentinpalkovic 98a6d87
Install @storybook/addon-docs if docs should be installed
valentinpalkovic 742898d
Refactor type definitions and logging in server-statics
valentinpalkovic dc4970b
Update AddonManager tests to use SupportedBuilder constants
valentinpalkovic f542c30
Refactor logging in server-statics to use project root for relative p…
valentinpalkovic ed93646
Refactor Compodoc logging in Angular generator for improved readability
valentinpalkovic 55ab695
Enable debug mode for init
valentinpalkovic 0636bca
Add yes option to GeneratorExecutionCommand for user confirmation
valentinpalkovic a94202e
WIP
valentinpalkovic 9b61d16
Merge remote-tracking branch 'origin/next' into valentin/cli-init-rework
valentinpalkovic 8803ec2
Refactor postinstall and logger integration across CLI components
valentinpalkovic db397d5
Refactor logger messages for consistency and clarity
valentinpalkovic fab118c
Fix tests
valentinpalkovic c43c7d1
Enhance GeneratorOptions type and streamline baseGenerator parameters
valentinpalkovic 8f4adc9
Refactor framework configuration in baseGenerator for simplicity
valentinpalkovic 494a348
Remove ConfigGenerationService and its associated tests
valentinpalkovic f2e303f
Add logger and prompt expectations in AddonConfigurationCommand tests
valentinpalkovic 22e819f
Refactor feature handling in CLI components to use Feature enum
valentinpalkovic c30500d
Add Feature enum to exports and clean up ConfigGenerationService exports
valentinpalkovic 82491a8
Fix tests
valentinpalkovic 950ca75
Fix tests
valentinpalkovic fc4c3dd
Refactor dependency management and introduce AddonService
valentinpalkovic b8954bb
Fix tests
valentinpalkovic d0ac4e6
Add logging for build and start processes in Angular Storybook builders
valentinpalkovic 48c1634
Enhance AddonService tests to include A11Y feature and verify addon c…
valentinpalkovic cc9ec9c
Fix tests
valentinpalkovic 650ba10
Merge branch 'next' into valentin/cli-init-rework
valentinpalkovic e14a93b
Refactor telemetry notification message formatting
valentinpalkovic e9b2e09
Update CircleCI configuration to use `--loglevel=debug` for create-st…
valentinpalkovic e4f9db7
Update CircleCI configuration to skip installation during Storybook i…
valentinpalkovic 9e0a69a
Enhance error logging in BUNProxy and NPMProxy classes
valentinpalkovic a2e2697
Refactor spinner and task log functions to support non-TTY environments
valentinpalkovic b0f26de
Refactor terminal check for spinner and task log functions
valentinpalkovic a289692
Update CircleCI configuration to remove redundant npm install during …
valentinpalkovic 74aa16a
Refactor Playwright installation logic in AddonVitestService
valentinpalkovic c1fd37a
Fix tests
valentinpalkovic f8641b6
Fix type issues
valentinpalkovic 8964063
Fix types
valentinpalkovic 7822623
Fix error handling in executeTaskWithSpinner to stop task on SIGINT
valentinpalkovic a85f440
Add nextjsToNextjsVite migration fix to allFixes export
valentinpalkovic e3d2f2c
Fix indentation handling in wrapTextForClackHint and update prompt-fu…
valentinpalkovic be57f8f
Fix tests
valentinpalkovic 96baa71
Fix tests
valentinpalkovic 44105d3
Fix tests
valentinpalkovic 6b32df7
Merge remote-tracking branch 'origin/next' into valentin/cli-init-rework
valentinpalkovic be6d33a
Refactor UserPreferencesCommand to use CommandOptions for better conf…
valentinpalkovic be0e21b
Delete integration test attempt
valentinpalkovic 0dd4c12
Enhance logging functions to conditionally log messages based on the …
valentinpalkovic bbc2123
Refactor telemetry logging to remove unnecessary newline and ensure c…
valentinpalkovic 9ff8653
Various logging improvements
valentinpalkovic 7775199
Refactor logging and task execution to improve message handling and r…
valentinpalkovic a08cb94
Improve logging
valentinpalkovic 04f6bcd
Core: Move builder-specific mocking logic into builders
valentinpalkovic 6aae3d9
Fix tests
valentinpalkovic 1f13f05
Fix tests
valentinpalkovic 48b24cc
Fix tests
valentinpalkovic efedfe9
Add caching for package.json files in JsPackageManager to optimize fi…
valentinpalkovic 14becd3
Merge branch 'valentin/cli-init-rework' into valentin/cli-init-docs-p…
valentinpalkovic 07dd5d4
Merge remote-tracking branch 'origin/next' into valentin/cli-init-rework
valentinpalkovic d08caed
Fix tests
valentinpalkovic 12ed766
Merge branch 'valentin/cli-init-rework' into valentin/cli-init-docs-p…
valentinpalkovic 03a3473
Minor logging fixes
valentinpalkovic 970ec6d
Merge branch 'valentin/cli-init-rework' into valentin/cli-init-docs-p…
valentinpalkovic ec0855b
Update feature selection in GeneratorExecutionCommand to use selected…
valentinpalkovic eef0799
Add support for Nuxt framework in get-storybook-info utility
valentinpalkovic 16b7aab
Merge branch 'valentin/cli-init-rework' into valentin/cli-init-docs-p…
valentinpalkovic aa29e7f
Refactor logging messages in AddonConfigurationCommand for clarity
valentinpalkovic 34f9bce
Enhance logger function signatures for better type safety and clarity…
valentinpalkovic 051edf1
Add 'doctor' event type to telemetry and implement telemetry logging …
valentinpalkovic 2915632
Improve error handling and logging in dependency installation process…
valentinpalkovic d5071f5
Refactor info logging in Vite logger to include spacing for improved …
valentinpalkovic 6ed2906
Merge branch 'valentin/cli-init-rework' into valentin/cli-init-docs-p…
valentinpalkovic e379604
Improve error logging in extractMockCalls function to include error m…
valentinpalkovic 22ae068
Update framework type definitions to allow null values in various com…
valentinpalkovic 056f22b
Refactor logging in FinalizationCommand to use warning level for debu…
valentinpalkovic d8c2ffd
Several test and type fixes
valentinpalkovic ca75222
Merge remote-tracking branch 'origin/valentin/cli-init-rework' into v…
valentinpalkovic 2fda23b
Cleanup
valentinpalkovic 423a1a9
Merge branch 'valentin/cli-init-rework' into valentin/cli-init-docs-p…
valentinpalkovic eb521b3
Remove obsolete outro's
valentinpalkovic 541b4df
Fix nextjs-vite automigration to update to the right version
valentinpalkovic 926fd23
Merge branch 'valentin/cli-init-rework' into valentin/cli-init-docs-p…
valentinpalkovic 31bee8b
Refactor upgrade process to improve logging and error handling; strea…
valentinpalkovic 264865b
Enhance upgrade logging by replacing log messages with step indicator…
valentinpalkovic 62527cd
Refactor migration summary logging to improve readability by formatti…
valentinpalkovic d201104
Add NX project detection error handling in ProjectDetectionCommand; t…
valentinpalkovic 28b96f1
Fix condition in ProjectDetectionCommand to correctly handle force op…
valentinpalkovic 04f7a99
Improve user prompt message formatting in ProjectDetectionCommand by …
valentinpalkovic eb1da8e
Cleanup logging new lines
valentinpalkovic 2497fc6
Update '--write-logs' option description to specify log file name; ad…
valentinpalkovic 4d8782a
Enhance ProjectDetectionCommand to include an additional check for th…
valentinpalkovic 31bda49
Merge remote-tracking branch 'origin/valentin/cli-init-rework' into v…
valentinpalkovic bada431
Refactor command execution across package managers to use a unified e…
valentinpalkovic a9da81c
Merge branch 'valentin/cli-init-rework' into valentin/cli-init-docs-p…
valentinpalkovic 71c8766
Merge remote-tracking branch 'origin/next' into valentin/cli-init-rework
valentinpalkovic d1f6bed
Merge branch 'valentin/cli-init-rework' into valentin/cli-init-docs-p…
valentinpalkovic a1366f7
Refactor BUNProxy command execution to use 'npx' instead of 'bun run'…
valentinpalkovic cd441a7
Fix: Update installDependencies method to use arrow function for impr…
valentinpalkovic 248b61a
Update CircleCI configuration to reduce parallelism for e2e-dev workf…
valentinpalkovic 82cd1be
Refactor package manager commands to replace runRemoteCommand with ru…
valentinpalkovic cabdff3
Merge branch 'valentin/cli-init-rework' into valentin/cli-init-docs-p…
valentinpalkovic 6321d48
Remove abstract method
valentinpalkovic 5f21e96
Merge branch 'valentin/cli-init-rework' into valentin/cli-init-docs-p…
valentinpalkovic 9f8743a
Fix tests
valentinpalkovic 2c7ac43
Enhance project scaffolding by adding 'Other' option for unsupported …
valentinpalkovic b5e87fc
Refactor command execution by removing 'shell: true' option in variou…
valentinpalkovic 871c615
Update telemetry notification message to remove unnecessary formattin…
valentinpalkovic bbc59ea
Remove unnecessary formatting from abort messages in task execution f…
valentinpalkovic a960afd
Refactor FinalizationCommand to remove selectedFeatures parameter, si…
valentinpalkovic 061781a
Remove unnecessary output from initiation completion logger for impro…
valentinpalkovic 78236e1
Add silent flag for npm package manager in Storybook initiation to re…
valentinpalkovic 3ffa86e
Refactor logging output in various components for improved clarity an…
valentinpalkovic 6e1bb50
Update Playwright installation prompt to indicate abort option; remov…
valentinpalkovic e54f891
Update code/lib/cli-storybook/src/upgrade.ts
valentinpalkovic 897cf7a
Refactor postinstall command execution to use spawnSync for synchrono…
valentinpalkovic ec6de36
Refactor sandbox function to remove unused borderColor variable and u…
valentinpalkovic 64fbedc
Fix command argument formatting in dispatcher.ts to remove unnecessar…
valentinpalkovic 9719b1d
Refactor postinstall command argument handling for improved clarity b…
valentinpalkovic bf72e84
Refactor command execution in link.ts to utilize executeCommand for i…
valentinpalkovic b56df2c
Remove 'skip-install' option from init function in sandbox-parts.ts f…
valentinpalkovic 993b2dd
Add debug logging for version handling in postinstall and package man…
valentinpalkovic eee9dbe
Enhance version handling in JsPackageManager by incorporating version…
valentinpalkovic 9ba0234
Refactor JsPackageManager tests to use spyOn for mocking latestVersio…
valentinpalkovic 1942e52
Update CircleCI configuration to remove loglevel flag from create-sto…
valentinpalkovic 8384d92
Update CircleCI configuration to change executor class from medium+ t…
valentinpalkovic cd83b83
Enhance logging in logger.ts to counteract default behavior of clack …
valentinpalkovic 1e614ac
Add warning suppression to customViteLogger in logger.ts to prevent d…
valentinpalkovic d54b4b7
Small cleanup
valentinpalkovic e550bfe
Add test
valentinpalkovic 8ccc6e1
Refactor package manager classes to remove synchronous command execut…
valentinpalkovic 0df27a4
Update framework-to-renderer and framework-to-builder mappings to cor…
valentinpalkovic 54fd6e5
Refactor getStorybookInfo function to ensure correct configuration di…
valentinpalkovic 879348e
Cleanup and small improvements
valentinpalkovic 6df4537
Refactor logger functions to use parameterized types for improved typ…
valentinpalkovic f1ac524
Refactor runCompodoc to use asynchronous package command execution fo…
valentinpalkovic a77ee36
Add comments
valentinpalkovic 79093a6
Update gitpick version in sandbox.ts to ensure compatibility and prev…
valentinpalkovic a90e13b
Refactor logger color constants to improve clarity and consistency in…
valentinpalkovic c74f361
Remove unused file
valentinpalkovic b3d776e
Implement dry run option for package.json updates in nextjs-to-nextjs…
valentinpalkovic 9d927b5
Small cleanup
valentinpalkovic 4fe5728
Refactor logging options in CLI commands to use --logfile for specify…
valentinpalkovic 9d044ba
Enhance logging functionality in Storybook initialization by passing …
valentinpalkovic 67d3622
Improve error handling in AddonConfigurationCommand by enhancing logg…
valentinpalkovic 45db1a6
Remove unused addon dependency functions for a11y and vitest, streaml…
valentinpalkovic 4a3c63a
Refactor PreflightCheckCommand to use options directly for package ma…
valentinpalkovic ecd6ecb
Improve error handling in ProjectDetectionCommand by allowing specifi…
valentinpalkovic f09bcd2
Small refactorings
valentinpalkovic b9f4440
Merge remote-tracking branch 'origin/next' into valentin/cli-init-rework
valentinpalkovic 38a925e
Remove --logfile option from CLI dev command, simplifying command opt…
valentinpalkovic 1441e05
Fix tests
valentinpalkovic a6955af
Merge remote-tracking branch 'origin/next' into valentin/cli-init-rework
valentinpalkovic 02f2ddb
Fix types
valentinpalkovic 34d3f5e
Fix tests
valentinpalkovic edcf22f
Merge branch 'next' into valentin/cli-init-rework
valentinpalkovic c4ce21c
Refactor JsPackageManager to normalize paths using resolve() for cons…
valentinpalkovic 37524ac
Merge remote-tracking branch 'origin/next' into valentin/cli-init-rework
valentinpalkovic aaad3f1
Update Yarn1Proxy to correctly pass command arguments with '--' separ…
valentinpalkovic b7fece0
Change default return value in getErrorLevel function from 'full' to …
valentinpalkovic 8e2937d
Merge branch 'valentin/cli-init-rework' into valentin/cli-init-rework…
valentinpalkovic baa5ad6
Refactor command execution in dispatcher and add synchronous command …
valentinpalkovic 116cf23
Refactor taskLog implementation to simplify logging conditions and re…
valentinpalkovic a84ea41
Refactor command spawning in dispatcher to separate command and argum…
valentinpalkovic b9eb956
Refactor telemetry error handling to conditionally send errors only w…
valentinpalkovic f9221a8
Update stdio configuration in AddonVitestService to inherit and pipe …
valentinpalkovic ae93da3
Update Playwright installation command in AddonVitestService to use '…
valentinpalkovic 80a78e7
Update automigration logging to handle optional fixId for improved cl…
valentinpalkovic eb59ba8
Merge remote-tracking branch 'origin/next' into valentin/cli-init-rework
valentinpalkovic 1be5aa8
Update yarn.lock file
valentinpalkovic 1ab6043
Add RSBuild support
valentinpalkovic e8977ce
Merge branch 'valentin/cli-init-rework' into valentin/cli-init-docs-p…
valentinpalkovic 5667637
Merge pull request #32921 from storybookjs/valentin/cli-init-docs-per…
valentinpalkovic a2d573b
Merge branch 'valentin/cli-init-rework' into valentin/cli-init-rework…
valentinpalkovic 5df8b2f
Merge pull request #32984 from storybookjs/valentin/cli-init-rework-d…
valentinpalkovic 11c1b66
Refactor package manager handling to use enums for type safety
valentinpalkovic 5771247
Refactor getApplicationFilesCountUncached to simplify command constru…
valentinpalkovic f712f28
Refactor JsPackageManagerFactory tests to use executeCommandSync
valentinpalkovic f3cf116
Refactor project type handling for improved consistency and type safety
valentinpalkovic 629e0a9
Reorganize logic for better structure and readability
valentinpalkovic f2862e2
Fix tests
valentinpalkovic 8e2cc64
Update configuration call in React Native generator to include contex…
valentinpalkovic 9e9d891
Import ProjectType from core for improved type handling in sandbox te…
valentinpalkovic edc314e
Refactor import statements in sandbox templates for improved clarity …
valentinpalkovic 87bd414
Update CircleCI configuration to remove 'dev' feature from Storybook …
valentinpalkovic da8535c
Update ProjectTypeService instantiation to handle package manager typ…
valentinpalkovic 2fb3ded
Fix tests
valentinpalkovic b764abe
Fix preset loading in yarn pnp mode
valentinpalkovic abdfb4d
Update taskLog function to require both interactive terminal and info…
valentinpalkovic 922b4f3
Refactor execCommandCountLines to accept command arguments and update…
valentinpalkovic 669c2a9
Enhance command execution by adding cross-platform support for Node-b…
valentinpalkovic 76d2b20
Removed `execa` from `create-storybook`
valentinpalkovic f2fb106
Remove `execa` across storybook packages
valentinpalkovic b13e056
Add 'ng' to command resolution and refactor command execution in Stor…
valentinpalkovic 881a637
Cleanup
valentinpalkovic c0d0a5e
Refactor logging in spinner functions to use conditional logging base…
valentinpalkovic 5ff022b
Cleanup
valentinpalkovic ad5b4ad
Update getApplicationFilesCountUncached to await execCommandCountLine…
valentinpalkovic 788ad55
Update yarn.lock
valentinpalkovic 9ded6e4
Add shell option to command execution in scaffoldNewProject
valentinpalkovic 659c72d
Refactor command execution in dispatcher to use internal executeComma…
valentinpalkovic 58e0e7e
Fix tests
valentinpalkovic d980a39
Fix tests
valentinpalkovic 47ba298
Enhance command execution in dispatcher by adding stdio inheritance f…
valentinpalkovic f340a68
Refactor PackageManagerName enum to use 'yarn' instead of 'yarn1' and…
valentinpalkovic aed6511
Shorten prompt
valentinpalkovic 5ad2c34
Addon-A11y: Fix a11y postinstall
valentinpalkovic b8c5e10
Refactor a11y postinstall to pass args as an object in runPackageCommand
valentinpalkovic f201f00
Refactor upgrade function to use PackageManagerName enum for better c…
valentinpalkovic fbdca15
Refactor UserPreferencesCommand and ProjectDetectionCommand to use Ar…
valentinpalkovic 1e131d4
Fix tests and linting
valentinpalkovic 3377ff9
Merge remote-tracking branch 'origin/next' into valentin/cli-init-rework
valentinpalkovic 32ecbaa
Linting
valentinpalkovic aa48b31
Update CLI color configuration to use cyan for info messages on Windo…
valentinpalkovic 26d7272
Fix exit code handling in dispatcher to default to 1 if undefined
valentinpalkovic c24667d
Refactor GeneratorExecutionCommand to use type assertion with 'satisf…
valentinpalkovic c0982c8
Merge remote-tracking branch 'origin/next' into valentin/cli-init-rework
valentinpalkovic 1aa4ae3
Add error names to AddonVitestPostinstall and AutomigrateError classe…
valentinpalkovic 2129a2f
Remove comment
valentinpalkovic 8ebf943
Refactor GeneratorExecutionCommand to use type assertion with 'as' fo…
valentinpalkovic 59d7b8e
Introduce --no-features flag for init command
valentinpalkovic 0abdc8c
Remove eslint-disable-next-line comments
valentinpalkovic e618441
Remove comments
valentinpalkovic 0cc0297
Adjust copy
valentinpalkovic 5fb40e9
Sort supported frameworks
valentinpalkovic 05b3522
Sort project type
valentinpalkovic ac3cb17
Sort third party frameworks
valentinpalkovic ede3808
Return error object key instead of an errors array for installPlaywri…
valentinpalkovic d239246
Change executor class from medium+ to small for test-init-features job
valentinpalkovic 82c9739
Fix version of @clack/prompts
valentinpalkovic eb452b4
Merge remote-tracking branch 'origin/next' into valentin/cli-init-rework
valentinpalkovic b0a5168
Sort community frameworks
valentinpalkovic 72a9017
FIx bug related to --skip-install being ignored in AddonConfiguration…
valentinpalkovic d484f05
Merge branch 'next' into valentin/cli-init-rework
valentinpalkovic 23c335a
Cleanup
valentinpalkovic 12e7055
Add tests for project type service and adjust error messaging
valentinpalkovic 9349f71
Remove debug log for features in run.ts
valentinpalkovic 7a16d82
Refactor telemetry notification logging to use info level and remove …
valentinpalkovic 4b955ff
Update configuration messages to reflect file extension based on lang…
valentinpalkovic d9ca7b4
Merge remote-tracking branch 'origin/next' into valentin/cli-init-rework
valentinpalkovic 07f890c
Update yarn lock
valentinpalkovic b01def1
Revert "Remove eslint-disable-next-line comments"
valentinpalkovic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Various logging improvements
- Loading branch information
commit 9ff8653e6950b3dcaf5cdb638b2a55fadf9d13a6
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.