Skip to content

Docs: Removed 'other' option from example in viewport.mdx #32732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nerdy-Girl wants to merge 1 commit into from
Closed

Docs: Removed 'other' option from example in viewport.mdx #32732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Removed 'other' option from example in viewport.mdx 
While updating the configuration of viewports in project we decided to assign icons to our custom viewports in Storybook. That's when we spotted that assigning 'other' doesn't show the icon.
I've checked the names of the available icons in `Devices` object in `iconList` array, and 'others' doesn't seem to be there.
  • Loading branch information
@Nerdy-Girl
Nerdy-Girl authored Oct 15, 2025
commit fd8fd00a261d9025d98dd70ea626f1b881586589
2 changes: 1 addition & 1 deletion docs/essentials/viewport.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ Type:
[key: string]: {
name: string;
styles: { height: string, width: string };
type: 'desktop' | 'mobile' | 'tablet' | 'other';
type: 'desktop' | 'mobile' | 'tablet';
};
}
```
Expand Down