Skip to content

Conversation

@ndelangen
Copy link
Member

@ndelangen ndelangen commented Oct 16, 2025

Closes #32611

What I did

I made a minor text change to the message printed when a user tries to downgrade (not supported)

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Bug Fixes
    • Updated the downgrade prevention message: consolidated into a single-line notification and removed the explicit reference to the 8.0 migration guide.
    • Updated the guidance link to point to the general migration/releases migration guide for upgrade instructions.

@ndelangen ndelangen changed the title Fix formatting in downgrade message for major version blocker CLI: Change message in downgrade-blocker Oct 16, 2025
@ndelangen ndelangen self-assigned this Oct 16, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 16, 2025

📝 Walkthrough

Walkthrough

Updated the Downgrade Not Supported user-facing message in the block-major-version module: the message text was consolidated into a single line and the explicit reference to the 8.0 migration guide was removed; the guidance link was changed to the releases migration guide URL.

Changes

Cohort / File(s) Summary
Downgrade Not Supported message
code/lib/cli-storybook/src/autoblock/block-major-version.ts
Consolidated the "Downgrade Not Supported" message into one line, removed the explicit 8.0 migration-guide instruction, and updated the guidance link to https://storybook.js.org/docs/releases/migration-guide?ref=upgrade.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch norbert/improve-downgrade-blocker-messaging

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 311c268 and ec8becc.

📒 Files selected for processing (1)
  • code/lib/cli-storybook/src/autoblock/block-major-version.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{js,jsx,json,html,ts,tsx,mjs}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{js,jsx,json,html,ts,tsx,mjs}: Run Prettier formatting on changed files before committing
Run ESLint on changed files and fix all errors/warnings before committing (use yarn lint:js:cmd <file>)

Files:

  • code/lib/cli-storybook/src/autoblock/block-major-version.ts
**/*.{ts,tsx,js,jsx,mjs}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Export functions from modules when they need to be unit-tested

Files:

  • code/lib/cli-storybook/src/autoblock/block-major-version.ts
code/**/*.{ts,tsx,js,jsx,mjs}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

In application code, use Storybook loggers instead of console.* (client code: storybook/internal/client-logger; server code: storybook/internal/node-logger)

Files:

  • code/lib/cli-storybook/src/autoblock/block-major-version.ts
{code/**,scripts/**}/**/*.{ts,tsx,js,jsx,mjs}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not use console.log, console.warn, or console.error directly unless in isolated files where importing loggers would significantly increase bundle size

Files:

  • code/lib/cli-storybook/src/autoblock/block-major-version.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: normal
  • GitHub Check: Core Unit Tests, windows-latest
🔇 Additional comments (1)
code/lib/cli-storybook/src/autoblock/block-major-version.ts (1)

75-83: Link verification confirms all changes are correct.

The migration guide link returns HTTP 200 and is accessible. The downgrade message block successfully removes hardcoded version references and provides clear, version-agnostic messaging. All PR objectives have been addressed and past feedback has been incorporated.


Comment @coderabbitai help to get the list of available commands and usage tips.

@ndelangen ndelangen requested a review from yannbf October 16, 2025 11:59
@ndelangen ndelangen marked this pull request as ready for review October 16, 2025 11:59
@nx-cloud
Copy link

nx-cloud bot commented Oct 16, 2025

View your CI Pipeline Execution ↗ for commit 354a48f

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 49s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-20 12:32:25 UTC

@storybook-app-bot
Copy link

Package Benchmarks

Commit: 311c268, ran on 16 October 2025 at 12:08:24 UTC

The following packages have significant changes to their size or dependencies:

@storybook/builder-webpack5

Before After Difference
Dependency count 187 187 0
Self size 68 KB 68 KB 0 B
Dependency size 31.85 MB 31.87 MB 🚨 +23 KB 🚨
Bundle Size Analyzer Link Link

@storybook/angular

Before After Difference
Dependency count 187 187 0
Self size 126 KB 126 KB 0 B
Dependency size 29.98 MB 30.00 MB 🚨 +23 KB 🚨
Bundle Size Analyzer Link Link

@storybook/ember

Before After Difference
Dependency count 191 191 0
Self size 17 KB 17 KB 0 B
Dependency size 28.56 MB 28.58 MB 🚨 +23 KB 🚨
Bundle Size Analyzer Link Link

@storybook/nextjs

Before After Difference
Dependency count 532 532 0
Self size 950 KB 950 KB 0 B
Dependency size 58.55 MB 58.57 MB 🚨 +23 KB 🚨
Bundle Size Analyzer Link Link

@storybook/react-webpack5

Before After Difference
Dependency count 272 272 0
Self size 25 KB 25 KB 0 B
Dependency size 43.51 MB 43.53 MB 🚨 +23 KB 🚨
Bundle Size Analyzer Link Link

@storybook/server-webpack5

Before After Difference
Dependency count 199 199 0
Self size 17 KB 17 KB 0 B
Dependency size 33.10 MB 33.12 MB 🚨 +23 KB 🚨
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 187 187 0
Self size 927 KB 927 KB 🎉 -73 B 🎉
Dependency size 79.92 MB 79.95 MB 🚨 +23 KB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 169 169 0
Self size 35 KB 35 KB 0 B
Dependency size 76.35 MB 76.38 MB 🚨 +23 KB 🚨
Bundle Size Analyzer Link Link

@storybook/preset-react-webpack

Before After Difference
Dependency count 170 170 0
Self size 21 KB 21 KB 0 B
Dependency size 31.00 MB 31.02 MB 🚨 +23 KB 🚨
Bundle Size Analyzer Link Link

@yannbf yannbf merged commit 7b49365 into next Oct 21, 2025
6 of 8 checks passed
@yannbf yannbf deleted the norbert/improve-downgrade-blocker-messaging branch October 21, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: SB10 - Wrong instruction message when downgrading Storybook

3 participants