Skip to content

Conversation

@jonniebigodes
Copy link
Contributor

@jonniebigodes jonniebigodes commented Oct 17, 2025

Follows up on #32646

What I did

With this pull request, the documentation was updated to reflect the recent change regarding the addon-jest location to prevent any broken links in our documentation.

What was done:

  • Updated the documentation references to point to the new addon's location

@ndelangen, when you have a moment, can you check this and follow up with me on it? You were the primary on the underlying pull request.

The patch:yes label was intentionally used so that it can be published in the current stable docs version.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Documentation
    • Updated Jest addon links in documentation to reference the standalone addon repository, replacing internal paths for improved accessibility and consistency.

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch ci:docs Run the CI jobs for documentation checks only. labels Oct 17, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 17, 2025

📝 Walkthrough

Walkthrough

Documentation links for the Jest addon are updated across two files to point from the internal monorepo path (storybookjs/storybook/tree/next/code/addons/jest) to the external repository (storybookjs/addon-jest).

Changes

Cohort / File(s) Change Summary
Documentation URL Updates
README.md, docs/configure/integration/frameworks-feature-support.mdx
Jest addon references updated from internal monorepo path to external storybookjs/addon-jest GitHub repository URL (appears in 3 locations across 2 files)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • storybookjs/storybook#32646: Main PR that updates documentation links to reference the external storybookjs/addon-jest repository, correlating with the Jest addon being extracted from the monorepo.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch docs_updates_to_addon_jest_location

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
README.md (1)

127-127: Update CODEOWNERS to remove stale jest addon path reference.

The README.md change is correct, and all Jest addon documentation references (README.md:127, framework support table) properly use the external GitHub URL. However, a stale commented reference remains in CODEOWNERS:19 (# /code/addons/jest/). While this is a comment, updating it maintains consistency across the codebase.

Remove or update the commented path in CODEOWNERS:19 from # /code/addons/jest/ to reflect that this addon is now externally maintained.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28ab482 and 1049588.

📒 Files selected for processing (2)
  • README.md (1 hunks)
  • docs/configure/integration/frameworks-feature-support.mdx (2 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/README.md

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Update package or feature README files when making significant changes

Files:

  • README.md
docs/**

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Update documentation under docs/ for significant changes, including migration guides for breaking changes

Files:

  • docs/configure/integration/frameworks-feature-support.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Danger JS
  • GitHub Check: Core Unit Tests, windows-latest
🔇 Additional comments (1)
docs/configure/integration/frameworks-feature-support.mdx (1)

37-37: Jest addon links are consistently updated across both feature support tables.

Both the Core and Community frameworks tables correctly reference the external Jest addon repository. The URL is consistent with other external addon references in these tables, and the table structure is preserved.

Also applies to: 86-86

@nx-cloud
Copy link

nx-cloud bot commented Oct 17, 2025

View your CI Pipeline Execution ↗ for commit 4d47a0d

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 48s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-20 16:22:27 UTC

@jonniebigodes jonniebigodes merged commit c24563d into next Oct 20, 2025
10 checks passed
@jonniebigodes jonniebigodes deleted the docs_updates_to_addon_jest_location branch October 20, 2025 16:27
ndelangen pushed a commit that referenced this pull request Oct 24, 2025
…_location

Docs: Adjust Addon jest location
(cherry picked from commit c24563d)
ndelangen pushed a commit that referenced this pull request Oct 24, 2025
…_location

Docs: Adjust Addon jest location
(cherry picked from commit c24563d)
@github-actions github-actions bot added patch:done Patch/release PRs already cherry-picked to main/release branch labels Oct 24, 2025
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:docs Run the CI jobs for documentation checks only. documentation patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants