-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Docs: Adjust Addon jest location #32755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughDocumentation links for the Jest addon are updated across two files to point from the internal monorepo path ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
127-127: Update CODEOWNERS to remove stale jest addon path reference.The README.md change is correct, and all Jest addon documentation references (README.md:127, framework support table) properly use the external GitHub URL. However, a stale commented reference remains in CODEOWNERS:19 (
# /code/addons/jest/). While this is a comment, updating it maintains consistency across the codebase.Remove or update the commented path in CODEOWNERS:19 from
# /code/addons/jest/to reflect that this addon is now externally maintained.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
README.md(1 hunks)docs/configure/integration/frameworks-feature-support.mdx(2 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/README.md
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Update package or feature README files when making significant changes
Files:
README.md
docs/**
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Update documentation under
docs/for significant changes, including migration guides for breaking changes
Files:
docs/configure/integration/frameworks-feature-support.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Danger JS
- GitHub Check: Core Unit Tests, windows-latest
🔇 Additional comments (1)
docs/configure/integration/frameworks-feature-support.mdx (1)
37-37: Jest addon links are consistently updated across both feature support tables.Both the Core and Community frameworks tables correctly reference the external Jest addon repository. The URL is consistent with other external addon references in these tables, and the table structure is preserved.
Also applies to: 86-86
|
View your CI Pipeline Execution ↗ for commit 4d47a0d
☁️ Nx Cloud last updated this comment at |
…_location Docs: Adjust Addon jest location (cherry picked from commit c24563d)
…_location Docs: Adjust Addon jest location (cherry picked from commit c24563d)
Follows up on #32646
What I did
With this pull request, the documentation was updated to reflect the recent change regarding the addon-jest location to prevent any broken links in our documentation.
What was done:
@ndelangen, when you have a moment, can you check this and follow up with me on it? You were the primary on the underlying pull request.
The
patch:yeslabel was intentionally used so that it can be published in the current stable docs version.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit