Skip to content

Conversation

@valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Oct 17, 2025

Closes #32743

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Updated the build configuration so preview support is included in the published build.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 17, 2025

📝 Walkthrough

Walkthrough

Added "./src/config/preview.ts" to the bundler.entries array in code/frameworks/nextjs-vite/package.json, expanding the package's public build entry points. No other functional or behavioral changes.

Changes

Cohort / File(s) Summary
Build entry point configuration
code/frameworks/nextjs-vite/package.json
Added "./src/config/preview.ts" to the bundler.entries array

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • storybookjs/storybook#32547: Modifies the same bundler.entries configuration and package.json exports to expose ./config/preview in the nextjs-vite package.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch valentin/fix-next-vite

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ea80f89 and 71995fc.

📒 Files selected for processing (1)
  • code/frameworks/nextjs-vite/package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • code/frameworks/nextjs-vite/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: normal
  • GitHub Check: Core Unit Tests, windows-latest

Comment @coderabbitai help to get the list of available commands and usage tips.

@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @vanessayuenn. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/18599415935

@nx-cloud
Copy link

nx-cloud bot commented Oct 17, 2025

View your CI Pipeline Execution ↗ for commit 71995fc

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 18s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-17 18:16:15 UTC

@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @vanessayuenn. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/18599415935

@vanessayuenn vanessayuenn marked this pull request as ready for review October 17, 2025 17:39
@vanessayuenn vanessayuenn added patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal bug and removed bug labels Oct 17, 2025
@yannbf yannbf changed the title Next.js-Vite: Fix config access Nextjs: Fix config access for Vite Oct 17, 2025
@vanessayuenn vanessayuenn merged commit 93328ce into main Oct 17, 2025
56 checks passed
@vanessayuenn vanessayuenn deleted the valentin/fix-next-vite branch October 17, 2025 18:33
@vanessayuenn vanessayuenn mentioned this pull request Oct 17, 2025
3 tasks
@coderabbitai coderabbitai bot mentioned this pull request Oct 22, 2025
8 tasks
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants