-
-
Notifications
You must be signed in to change notification settings - Fork 10k
CLI: Add Stencil Integration #32768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
CLI: Add Stencil Integration #32768
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7643113
CLI: add support for generating Storybook with Stencil
artursopelnik b7670bb
fix(stencil): CLI detect stencil projects and use vite per default 🚨
artursopelnik 684fd76
fix(stencil): revert early documentation until feature is ready
artursopelnik c172356
Merge remote-tracking branch 'origin/next' into pr/artursopelnik/32768
valentinpalkovic 36e23c2
Add Stencil support across various modules
valentinpalkovic 95098e2
Refactor builder support by replacing Stencil with Vite
valentinpalkovic e8e122b
Add Stencil preset support in ProjectTypeService
valentinpalkovic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add Stencil support across various modules
- Added 'stencil' to the list of supported frameworks in generate-source-files.ts and frameworks.ts. - Updated ProjectType enum to include STENCIL. - Enhanced framework detection service to recognize Stencil configurations. - Registered Stencil generator in registerGenerators.ts. - Updated builder and renderer mappings to include Stencil. - Added necessary imports and configurations in the Stencil generator module.
- Loading branch information
commit 36e23c215daf940edc0df5b0a87bb16fd50466f2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,4 +4,5 @@ export enum SupportedBuilder { | |
| VITE = 'vite', | ||
| // COMMUNITY | ||
| RSBUILD = 'rsbuild', | ||
| STENCIL = 'stencil', | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,16 @@ | ||
| import { baseGenerator } from '../baseGenerator'; | ||
| import type { Generator } from '../types'; | ||
| import { ProjectType } from 'storybook/internal/cli'; | ||
| import { SupportedRenderer } from 'storybook/internal/types'; | ||
|
|
||
| const generator: Generator = async (packageManager, npmOptions, options) => { | ||
| await baseGenerator(packageManager, npmOptions, options, 'stencil', {}, 'stencil'); | ||
| }; | ||
| import { defineGeneratorModule } from '../modules/GeneratorModule'; | ||
|
|
||
| export default generator; | ||
| export default defineGeneratorModule({ | ||
| metadata: { | ||
| projectType: ProjectType.STENCIL, | ||
| renderer: SupportedRenderer.STENCIL, | ||
| }, | ||
| configure: async () => { | ||
| return { | ||
| extraPackages: ['@stencil/storybook-plugin'], | ||
| }; | ||
| }, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: storybookjs/storybook
Length of output: 213
🏁 Script executed:
Repository: storybookjs/storybook
Length of output: 147
🏁 Script executed:
# Also check the framework.ts file to see context around lines 39 and 65 wc -l code/core/src/common/utils/framework.ts head -n 80 code/core/src/common/utils/framework.tsRepository: storybookjs/storybook
Length of output: 3487
🏁 Script executed:
Repository: storybookjs/storybook
Length of output: 484
🏁 Script executed:
Repository: storybookjs/storybook
Length of output: 989
STENCIL types are not defined in the type system.
The enums
SupportedRenderer.STENCILandSupportedFramework.STENCILdo not exist incode/core/src/types/modules/renderers.tsorcode/core/src/types/modules/frameworks.ts. These type definitions must be added before the mappings at lines 39 and 65 in framework.ts can be used. Note thatframeworks.tsis marked as auto-generated and should not be edited directly.🤖 Prompt for AI Agents