-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Maintenance: Remove addon-jest #32771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis PR completely removes the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes This change spans 15+ affected files across multiple directories with a mix of deletions and configuration updates. While the edits are primarily file removals (lower complexity per deletion), the distributed scope requires verification that no other dependencies reference the removed exports, types, and constants across the codebase. Possibly related PRs
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
scripts/verdaccio.yaml (1)
128-131: Verify that proxying to npmjs is the intended behavior after removing addon-jest code.This change adds
@storybook/addon-jestto Verdaccio's external packages that proxy to npmjs. While the placement in the "packages never hosted in this monorepo" section is correct, this represents a semantic shift: the addon will now resolve to the published npmjs version instead of the local source code.Ensure that:
- Tests and CI pipelines do not depend on local addon-jest behavior or unpublished versions
- The published npmjs version is compatible with the monorepo after the source code removal
- The transition does not introduce subtle failures in builds or test runs
Consider adding a TODO comment (similar to line 173–174 for
@storybook/semver) to document this temporary proxy setup:~ '@storybook/addon-jest': + # TODO: Remove this once the addon-jest npm package is no longer needed by dependents access: $all publish: $all proxy: npmjsThis clarifies intent and aids future maintenance when the addon can be fully removed from the Verdaccio config.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
code/addons/jest/docs/storybook-addon-jest.gifis excluded by!**/*.gifcode/yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (20)
.gitignore(0 hunks)code/addons/jest/README.md(0 hunks)code/addons/jest/manager.js(0 hunks)code/addons/jest/package.json(0 hunks)code/addons/jest/project.json(0 hunks)code/addons/jest/src/components/Message.tsx(0 hunks)code/addons/jest/src/components/Panel.tsx(0 hunks)code/addons/jest/src/components/Result.tsx(0 hunks)code/addons/jest/src/hoc/provideJestResult.tsx(0 hunks)code/addons/jest/src/index.ts(0 hunks)code/addons/jest/src/manager.tsx(0 hunks)code/addons/jest/src/shared.test.ts(0 hunks)code/addons/jest/src/shared.ts(0 hunks)code/addons/jest/src/types.ts(0 hunks)code/addons/jest/tsconfig.json(0 hunks)code/addons/jest/vitest.config.ts(0 hunks)code/core/src/common/versions.ts(0 hunks)code/core/src/core-server/__for-testing__/main.ts(0 hunks)code/package.json(0 hunks)scripts/verdaccio.yaml(1 hunks)
💤 Files with no reviewable changes (19)
- code/addons/jest/src/types.ts
- code/package.json
- code/core/src/core-server/for-testing/main.ts
- .gitignore
- code/addons/jest/src/components/Result.tsx
- code/addons/jest/src/components/Message.tsx
- code/core/src/common/versions.ts
- code/addons/jest/src/index.ts
- code/addons/jest/src/components/Panel.tsx
- code/addons/jest/src/manager.tsx
- code/addons/jest/vitest.config.ts
- code/addons/jest/README.md
- code/addons/jest/manager.js
- code/addons/jest/src/shared.test.ts
- code/addons/jest/package.json
- code/addons/jest/tsconfig.json
- code/addons/jest/src/shared.ts
- code/addons/jest/src/hoc/provideJestResult.tsx
- code/addons/jest/project.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: normal
- GitHub Check: Core Unit Tests, windows-latest
|
View your CI Pipeline Execution ↗ for commit 5229548
☁️ Nx Cloud last updated this comment at |
What I did
Remove addon-jest from the
mainbranch, as it's already been removed fromnextbranchChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit