Skip to content

Conversation

@ndelangen
Copy link
Member

@ndelangen ndelangen commented Oct 20, 2025

What I did

Remove addon-jest from the main branch, as it's already been removed from next branch

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • The Jest addon has been removed from Storybook. Jest test integration is no longer available within the Storybook interface.

@ndelangen ndelangen changed the title remove addon-jest Maintenance: Remove addon-jest Oct 20, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 20, 2025

📝 Walkthrough

Walkthrough

This PR completely removes the @storybook/addon-jest package from the Storybook monorepo, including all source code, configuration files, tests, dependencies, and references across the core codebase.

Changes

Cohort / File(s) Summary
Jest addon source and components
code/addons/jest/src/components/Message.tsx, code/addons/jest/src/components/Panel.tsx, code/addons/jest/src/components/Result.tsx, code/addons/jest/src/hoc/provideJestResult.tsx, code/addons/jest/src/index.ts, code/addons/jest/src/manager.tsx, code/addons/jest/src/shared.ts, code/addons/jest/src/shared.test.ts, code/addons/jest/src/types.ts
Removed entire Jest addon implementation including UI components, higher-order components for test result injection, manager registration, shared utilities, type definitions, and associated tests.
Jest addon configuration and build files
code/addons/jest/README.md, code/addons/jest/manager.js, code/addons/jest/package.json, code/addons/jest/project.json, code/addons/jest/tsconfig.json, code/addons/jest/vitest.config.ts
Removed addon documentation, package metadata, NX project configuration, and build/test configurations.
Core monorepo references
code/core/src/common/versions.ts, code/core/src/core-server/__for-testing__/main.ts, code/package.json, .gitignore
Removed Jest addon version entry, test configuration reference, workspace dependency declaration, and .gitignore tracking rule.
Verdaccio registry configuration
scripts/verdaccio.yaml
Added new Verdaccio package entry for @storybook/addon-jest with npm proxy configuration.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

This change spans 15+ affected files across multiple directories with a mix of deletions and configuration updates. While the edits are primarily file removals (lower complexity per deletion), the distributed scope requires verification that no other dependencies reference the removed exports, types, and constants across the codebase.

Possibly related PRs

  • storybookjs/storybook#32646: Directly related removal of the same @storybook/addon-jest package and all associated monorepo references during addon extraction/deprecation.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch norbert/delete-addon-jest-main

Comment @coderabbitai help to get the list of available commands and usage tips.

@ndelangen ndelangen self-assigned this Oct 20, 2025
@ndelangen ndelangen added maintenance User-facing maintenance tasks addon: jest ci:normal labels Oct 20, 2025
@ndelangen ndelangen requested a review from JReinhold October 20, 2025 07:35
@ndelangen ndelangen marked this pull request as ready for review October 20, 2025 07:36
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
scripts/verdaccio.yaml (1)

128-131: Verify that proxying to npmjs is the intended behavior after removing addon-jest code.

This change adds @storybook/addon-jest to Verdaccio's external packages that proxy to npmjs. While the placement in the "packages never hosted in this monorepo" section is correct, this represents a semantic shift: the addon will now resolve to the published npmjs version instead of the local source code.

Ensure that:

  1. Tests and CI pipelines do not depend on local addon-jest behavior or unpublished versions
  2. The published npmjs version is compatible with the monorepo after the source code removal
  3. The transition does not introduce subtle failures in builds or test runs

Consider adding a TODO comment (similar to line 173–174 for @storybook/semver) to document this temporary proxy setup:

~  '@storybook/addon-jest':
+    # TODO: Remove this once the addon-jest npm package is no longer needed by dependents
     access: $all
     publish: $all
     proxy: npmjs

This clarifies intent and aids future maintenance when the addon can be fully removed from the Verdaccio config.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 93328ce and 5229548.

⛔ Files ignored due to path filters (2)
  • code/addons/jest/docs/storybook-addon-jest.gif is excluded by !**/*.gif
  • code/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (20)
  • .gitignore (0 hunks)
  • code/addons/jest/README.md (0 hunks)
  • code/addons/jest/manager.js (0 hunks)
  • code/addons/jest/package.json (0 hunks)
  • code/addons/jest/project.json (0 hunks)
  • code/addons/jest/src/components/Message.tsx (0 hunks)
  • code/addons/jest/src/components/Panel.tsx (0 hunks)
  • code/addons/jest/src/components/Result.tsx (0 hunks)
  • code/addons/jest/src/hoc/provideJestResult.tsx (0 hunks)
  • code/addons/jest/src/index.ts (0 hunks)
  • code/addons/jest/src/manager.tsx (0 hunks)
  • code/addons/jest/src/shared.test.ts (0 hunks)
  • code/addons/jest/src/shared.ts (0 hunks)
  • code/addons/jest/src/types.ts (0 hunks)
  • code/addons/jest/tsconfig.json (0 hunks)
  • code/addons/jest/vitest.config.ts (0 hunks)
  • code/core/src/common/versions.ts (0 hunks)
  • code/core/src/core-server/__for-testing__/main.ts (0 hunks)
  • code/package.json (0 hunks)
  • scripts/verdaccio.yaml (1 hunks)
💤 Files with no reviewable changes (19)
  • code/addons/jest/src/types.ts
  • code/package.json
  • code/core/src/core-server/for-testing/main.ts
  • .gitignore
  • code/addons/jest/src/components/Result.tsx
  • code/addons/jest/src/components/Message.tsx
  • code/core/src/common/versions.ts
  • code/addons/jest/src/index.ts
  • code/addons/jest/src/components/Panel.tsx
  • code/addons/jest/src/manager.tsx
  • code/addons/jest/vitest.config.ts
  • code/addons/jest/README.md
  • code/addons/jest/manager.js
  • code/addons/jest/src/shared.test.ts
  • code/addons/jest/package.json
  • code/addons/jest/tsconfig.json
  • code/addons/jest/src/shared.ts
  • code/addons/jest/src/hoc/provideJestResult.tsx
  • code/addons/jest/project.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: normal
  • GitHub Check: Core Unit Tests, windows-latest

@nx-cloud
Copy link

nx-cloud bot commented Oct 20, 2025

View your CI Pipeline Execution ↗ for commit 5229548

Command Status Duration Result
nx run-many -t build -c production --parallel=3 ✅ Succeeded 3s View ↗
nx run-many -t check -c production --parallel=7 ✅ Succeeded 1m 4s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-20 10:40:02 UTC

@ndelangen ndelangen merged commit 192acfd into main Oct 20, 2025
64 of 70 checks passed
@ndelangen ndelangen deleted the norbert/delete-addon-jest-main branch October 20, 2025 12:07
@coderabbitai coderabbitai bot mentioned this pull request Dec 4, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addon: jest ci:normal maintenance User-facing maintenance tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants