-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Onboarding: Guided tour checklist #32795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
211 commits
Select commit
Hold shift + click to select a range
d581a3b
Fix invalid story specifier for non-story pages (e.g. settings)
ghengeveld 4c9e929
Prevent pages from scrolling beyond the layout container (shifting th…
ghengeveld e662368
Add Collapsible and FocusProxy components
ghengeveld b0fbf3c
Pull Card component out of TestingModule and make it more generic
ghengeveld 0ff85f0
Add generic Listbox component and allow Button to be used as label
ghengeveld 5110838
Add Guided Tour page and ChecklistModule
ghengeveld e7ca5c1
UI tweaks
ghengeveld b91e701
TypeScript fix
ghengeveld 3b384b4
Merge branch 'next' into onboarding-checklist
ghengeveld f473e21
Rename 'Guided tour' to 'Guide'
ghengeveld 69cc7ba
Add support for task dependencies and update ChecklistModule to show …
ghengeveld ce5ebc0
Change ChecklistModule based on progress
ghengeveld 4cd3631
Support custom action button label
ghengeveld bd55f1e
Allow muting the ChecklistModule, either permanently or for a particu…
ghengeveld c89bce5
Change selection of items in the ChecklistModule
ghengeveld 02c9aca
Tweak spacing for visual consistency
ghengeveld d685d12
Make ChecklistModule collapsible and fix card shadow styling
ghengeveld 489113d
Split Card 'All' story into separate stories
ghengeveld e23d3f9
Drop superfluous initialCollapsed arg for Collapsible
ghengeveld b7e60c5
Hide ChecklistModule in prod mode
ghengeveld 46081e5
Support providing useCollapsible state to Collapsible
ghengeveld b92f735
Animate closing of last checklist task
ghengeveld 2e65137
Fix a11y issue
ghengeveld 6c633c4
Don't show Guide page in production mode
ghengeveld 91a3519
Fix visual snapshot for FocusProxy
ghengeveld 770baf7
Prevent showing empty checklist on first render when all tasks are co…
ghengeveld 84440e2
Move ChecklistModule above search and fix Explorer stories to show th…
ghengeveld 36e688a
Revert "Tweak spacing for visual consistency"
ghengeveld 385066d
Fix sidebar spacing
ghengeveld 7c51785
More flexible component API
ghengeveld 1a917a3
Collapse spacing when ChecklistModule is hidden
ghengeveld 36df52d
Drop useless story
ghengeveld 69eac58
Add progress indicator, animate progress value changes and add menu t…
ghengeveld 5d1b37e
Centralize hashchange detection and add several FocusRing utility com…
ghengeveld 9f8bf34
Add story for GuidePage and hoist store/state up from Checklist to Gu…
ghengeveld 7db2e15
Update sidebar menu to use Listbox components and put What's new last…
ghengeveld 0e109db
Pull checklist logic out into a hook
ghengeveld 4289e0e
Fix progress updates for guide in sidebar menu
ghengeveld 000cae7
Refactor checklist state management to use accepted and done properti…
ghengeveld 076adee
Fix import
ghengeveld c5cc465
Fix collapsible state
ghengeveld 0f5f1a6
Avoid passing unsupported attribute to SVG
ghengeveld 894f311
Don't show link to onboarding guide in prod mode
ghengeveld f5f0ad8
Add missing key prop
ghengeveld dcfe2fc
Avoid conditional hook call
ghengeveld 49492f0
Avoid NodeJS type in client-side file
ghengeveld 2a2eb6c
Fix type errors and story data
ghengeveld b82881f
Simplify TextFlip component
ghengeveld 4c0104f
Use ref to track latest text value so onAnimationEnd always syncs wit…
ghengeveld 8030fc3
Fix numeric sorting
ghengeveld 230577e
Fix invalid nesting of buttons
ghengeveld 405b934
Fix invalid DOM nesting
ghengeveld 1eea810
Update checklist according to latest proposal
ghengeveld 8e471bf
Update checklistData according to latest concept
ghengeveld c0eb34b
Handle narrow width for ChecklistModule by introducing an Optional co…
ghengeveld 94c5c62
Update checklist criteria and checks
ghengeveld 5f1bd57
Persist autocompleted items in node_modules/.cache and add telemetry
ghengeveld 5ba33eb
Support conditional guide items
ghengeveld 9d28bb0
Use simpler navigation API
ghengeveld cd97967
Add guided tour and intent survey to checklist
ghengeveld 10917ad
Show completion message instead of mute toggle when all tasks are com…
ghengeveld 589f1f0
Prevent onboarding from returning to splash screen
ghengeveld 624bfc6
Fix build command
ghengeveld 5845f57
Prevent guided tour from showing intent survey if it has already been…
ghengeveld 1411869
Ensure subscription callback is a function
ghengeveld 70914fe
Revert back to using ReactDOM.render
ghengeveld af5996a
Completion detection for install-vitest and run-tests tasks
ghengeveld 571eb37
Don't skip checklist tasks when closing tour tooltip
ghengeveld da9c7b8
Better looking code blocks
ghengeveld 8a27b33
Fix mocks
ghengeveld 2adfb83
Add items for installing dependencies
ghengeveld 870ab94
Use createRoot rather than deprecated ReactDOM.render
ghengeveld d6e6f09
Fix testing widget overflow to allow highlighting for onboarding
ghengeveld 85b9fa1
Reduce update frequency by throttling index updates
ghengeveld 8c5c660
Pass index to available function to receive updates, and don't pass i…
ghengeveld 02917c4
Make content a function
ghengeveld 073778c
Ignore example stories where appropriate
ghengeveld bc7ac39
Prevent clicking on underlying collapse toggle when using checklist r…
ghengeveld 9aef937
Fix addon identifier
ghengeveld e311a22
Rename Tour to TourGuide and make it a generic component
ghengeveld 1f79889
Make renderTourGuide a static method on the TourGuide component
ghengeveld 1c8bb66
Fix GuidePage sidebar toggle
ghengeveld 056a80f
Refactor onboarding components: consolidate HighlightElement and Tour…
ghengeveld f0dfab7
Refactor useChecklist to provide all data needed in Checklist component
ghengeveld d9df904
Animate the completion of a checklist item in the widget
ghengeveld 2fd404c
Animate strikethrough
ghengeveld bb87ae0
Hide certain checklist items once completed, and update API for items…
ghengeveld 7591d75
Reset itemIndex to only include ready items, in order to fix round-ro…
ghengeveld 88afdc1
Hide action buttons in checklist module unless hovering the item
ghengeveld 64c5d96
Update FocusProxy to use a data attribute rather than id attribute
ghengeveld c2eaf69
Merge branch 'next' into onboarding-checklist
ghengeveld c051458
Merge branch 'onboarding-checklist' into onboarding-guide
ghengeveld 760764f
Merge branch 'onboarding-guide' into checklist-tasks
ghengeveld e49e0ba
Replace react-transition-group with react-transition-state
ghengeveld f367ae4
Fix TS type issue
ghengeveld 990d21e
Merge branch 'onboarding-checklist' into onboarding-guide
ghengeveld eb45f76
Handle review comments
ghengeveld 3cac5c1
Fix type shenanigans
ghengeveld e6456e2
Merge pull request #32874 from storybookjs/onboarding-guide
ghengeveld bc804e3
Merge branch 'onboarding-checklist' into checklist-tasks
ghengeveld aad4c79
Remove storybook/internal/manager/manager-stores
ghengeveld 48c0efb
Merge pull request #32799 from storybookjs/checklist-tasks
ghengeveld a38f6f0
Typecheck fixes
ghengeveld d8293cb
Update progress calculation in useChecklist to handle zero available …
ghengeveld 6327559
Enhance equality check in checklist utility to ensure key length matc…
ghengeveld f329817
Handle checklist initialization errors
ghengeveld 858d2a1
Move manager components out of core
ghengeveld 7217660
Refactor onboarding and checklist components to import TourGuide and …
ghengeveld d8e826e
Refactor checklist store management by creating a dedicated `createCh…
ghengeveld 2977758
Add missing story context
ghengeveld aecbc3b
Fix bad content
ghengeveld 8990d19
Avoid inline styles
ghengeveld 9dcb0da
Ensure play function waits for timeouts
ghengeveld 8189bb1
Keep collapsed while loading
ghengeveld ab25430
Remove duplicate tooltip
ghengeveld 5a83618
Fix ariaLabel props
ghengeveld 31255a1
Only animate opacity
ghengeveld 05d50a0
Reduce timeout
ghengeveld e54c910
Fix invalid keys
ghengeveld 4af5c3a
Fix sidebar menu tests, keep it open for toggle actions and fix docum…
ghengeveld d7e0a57
Fix e2e test for fullscreen toggle
ghengeveld 32ee70d
Close menu when hiding sidebar
ghengeveld c75648e
Fix E2E tests for menu toggles
ghengeveld 0ffd1f7
Update fullscreen toggling test logic for proper order of actions
ghengeveld 659e860
Properly close settings menu
ghengeveld a3b63a3
No need for refs in deps
ghengeveld 90a716c
Remove nonexistent keys
ghengeveld 5fa9a01
Avoid deleting nonexistent items
ghengeveld b51a36d
Suppress some warnings during test
ghengeveld 2e80f98
Share play function between stories
ghengeveld 505e7ec
Fix contrast
ghengeveld df04cb7
Use proper heading level
ghengeveld 48a1bc8
Clean up and ignore example stories
ghengeveld 2eda64c
Merge branch 'next' into onboarding-checklist
ghengeveld b9437f2
Fix type
ghengeveld 81cf1f2
Avoid locator conflict
ghengeveld 5be3a1f
align usage of Fragment to rest of repo
ndelangen b753270
align usage of ReactNode to rest of repo
ndelangen e00e1ee
Update code/vitest-setup.ts
ghengeveld 46cc469
Ignore error stack trace in Chromatic
ghengeveld 1defe4c
A cleaner way to disable onboarding search param
ghengeveld fb4f186
Use compound component pattern
ghengeveld 331d34d
Merge styles
ghengeveld 35fa041
Add step definitions
ghengeveld f0ac445
Linting
ghengeveld 8f91857
Use useId from react-aria instead of react to maintain React 17 compa…
ghengeveld 50b98b6
Wrap interpolate-size in feature detection media query
ghengeveld 135a375
Respect disabled prop
ghengeveld 72e49a8
Remove unused react-transition-group styles
ghengeveld 68ef860
Remove unused outlineStyles prop
ghengeveld 2e876cc
Remove unused outlineStyles prop
ghengeveld 703de3e
Add docblock
ghengeveld 21e2d4a
Fix story styles
ghengeveld f4de5b2
Fix story styles
ghengeveld baa9d8b
Merge branch 'next' into onboarding-checklist
ndelangen 87b19f3
Ensure proper ARIA behavior for readOnly button
ghengeveld ec29889
Fix ARIA attributes for readOnly button handling
ghengeveld 2df3d62
Avoid inline identifiers (use constants instead) and fix autodetectio…
ghengeveld cba209c
Merge branch 'next' into onboarding-checklist
ndelangen a585c45
Content styling
ghengeveld 15cc514
Add support for asset URLs in getDocsUrl util
ghengeveld 5d7f60a
Fix getDocsUrl to use 'asset' parameter and add corresponding tests
ghengeveld 941600c
Remove invalid and unnecessary role attribute for readOnly buttons
ghengeveld 4e8d31d
No point in snapshotting an animation
ghengeveld 499a8a9
Set fixed height for story to avoid flake
ghengeveld d88ac22
Increase height so particles always fit
ghengeveld 839b6a7
Mark dependent steps as skipped if one of their ancestors is skipped
ghengeveld 0baca2b
fix bundle size
ndelangen 3a02ac2
Merge branch 'next' into onboarding-checklist
ndelangen 7eaa90f
Update content
kylegach e0ea357
Update checklist hierarchy styles
kylegach b29a44a
Merge branch 'next' into onboarding-checklist
ndelangen 75f3867
Avoid marking completed items as skipped
ghengeveld 9b509a7
Merge branch 'next' into onboarding-checklist
ndelangen 6122ed5
Fix cursor for clickable rows
ghengeveld 1760149
Rename TestingModule and ChecklistModule to TestingWidget and Checkli…
ghengeveld 499b583
Merge branch 'next' into onboarding-checklist
ndelangen cbbeb47
Merge branch 'next' into onboarding-checklist
ghengeveld 4caa1e1
Remove unused prop which was replaced by the Listbox.HoverItem component
ghengeveld d6f26a6
Remove stray import
ghengeveld 44543da
Add stopPropagation() to prevent nested action button from triggering…
ghengeveld 50bba49
Revert key rename to avoid breaking change
ghengeveld d0cb3b7
Ensure state update is immutable
ghengeveld 131ecbb
Store checklist state as single object rather than arrays
ghengeveld 27a8514
Update how checklist updates are tracked
ghengeveld 4baf5db
Only log telemetry message once
ghengeveld 679e4a6
Merge branch 'next' into onboarding-checklist
ndelangen dc8603e
Rework telemetry notification to ensure it is logged only once and im…
ghengeveld c141c98
wip
ghengeveld dec8cfc
Merge branch 'next' into onboarding-checklist
ndelangen c71d37f
Fix incorrect state initialization from persistence, which was overri…
ghengeveld 26b351c
Rename property 'values' to 'items'
ghengeveld 89faea2
Consistent keyFn usage
ghengeveld c5f7c39
Add JSDoc
ghengeveld bff2d46
Remove incorrect return type
ghengeveld a08e8d0
Add JSDoc
ghengeveld 0f548b3
Use dequal in place of own implementation
ghengeveld 6925f08
Add missing mock data
ghengeveld 1cfaf81
improve type-safety
ndelangen 2d2f717
fix stories? I hope. just maybe. it would be cool
ndelangen cfccdc6
Enhance type safety in checklist utility by refining item state handl…
ndelangen 08bdbd0
Merge branch 'next' into onboarding-checklist
ndelangen a37edcb
Enforce version number for docs-assets links
ghengeveld 8a9fa97
Persisted object should be partial
ghengeveld 5d02fb8
Fix checklist store types
ghengeveld d79a162
Run check once preview is ready, because index is invalidated only on…
ghengeveld d42319a
Only store mutedAt in user-local storage
ghengeveld bf693a3
Ensure settings are properly written, and rename identifiers to camel…
ghengeveld 5f29a50
Add missing api mocks
ghengeveld a65a429
Throttle at callsite
ghengeveld 2ff8d29
Fix story data
ghengeveld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Suppress some warnings during test
- Loading branch information
commit b51a36d1775ef3c21a35e2be395ab7d3b07a487f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.