Skip to content

Conversation

@valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Oct 30, 2025

Relates #32895 (comment)

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Documentation
    • Updated Vitest configuration examples across Vitest 3/4 and multiple frameworks to reflect the current recommended setup.

@valentinpalkovic valentinpalkovic added the ci:docs Run the CI jobs for documentation checks only. label Oct 30, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2025

📝 Walkthrough

Walkthrough

Removed the extends: true property from defineProject(...) configuration calls in Vitest example snippets documented for multiple framework integrations (Vitest 3/4). The remaining configuration structure for plugins, test settings, browser configuration, and Storybook integration remains intact.

Changes

Cohort / File(s) Summary
Vitest Configuration Examples
docs/_snippets/vitest-plugin-vitest-config.md
Removed extends: true property from multiple defineProject(...) calls across Vitest 3/4 framework integration examples

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Minor documentation change with repetitive property removals across example configurations
  • No functional code changes; purely documentation updates to code snippets

Possibly related PRs

  • storybookjs/storybook#32843: Modifies the same Vitest configuration snippet file with related defineProject(...) object shape changes
  • storybookjs/storybook#32753: Handles extends: true logic in addon code when merging/transforming Vitest configurations, providing context for why the example snippet changes may be needed

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dd000a8 and b1b4106.

📒 Files selected for processing (1)
  • docs/_snippets/vitest-plugin-vitest-config.md (0 hunks)
💤 Files with no reviewable changes (1)
  • docs/_snippets/vitest-plugin-vitest-config.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Danger JS
  • GitHub Check: Core Unit Tests, windows-latest

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Oct 30, 2025

View your CI Pipeline Execution ↗ for commit b512412

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-30 15:47:26 UTC

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Oct 30, 2025
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valentinpalkovic, thank you so much for taking the time to put together this pull request and catching the typo in the documentation. Appreciate it 🙏 !

Everything is good on my end, and I will merge this once the checklist is cleared.

@jonniebigodes jonniebigodes merged commit b079045 into next Oct 30, 2025
10 checks passed
@jonniebigodes jonniebigodes deleted the valentin/fix-vitest-documentation branch October 30, 2025 15:51
ndelangen pushed a commit that referenced this pull request Nov 3, 2025
…ntation

Docs: Fix Vitest option instructions
(cherry picked from commit b079045)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:docs Run the CI jobs for documentation checks only. documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants